Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Side by Side Diff: src/compiler/x64/instruction-selector-x64.cc

Issue 1779713009: Implement optional turbofan UnalignedLoad and UnalignedStore operators (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix failures in cctest/test-run-wasm-64/Run_Wasm_LoadStoreI64_sx due to missing implementation of U… Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <algorithm> 5 #include <algorithm>
6 6
7 #include "src/base/adapters.h" 7 #include "src/base/adapters.h"
8 #include "src/compiler/instruction-selector-impl.h" 8 #include "src/compiler/instruction-selector-impl.h"
9 #include "src/compiler/node-matchers.h" 9 #include "src/compiler/node-matchers.h"
10 #include "src/compiler/node-properties.h" 10 #include "src/compiler/node-properties.h"
(...skipping 246 matching lines...) Expand 10 before | Expand all | Expand 10 after
257 InstructionCode code = 257 InstructionCode code =
258 opcode | AddressingModeField::encode(addressing_mode); 258 opcode | AddressingModeField::encode(addressing_mode);
259 InstructionOperand value_operand = 259 InstructionOperand value_operand =
260 g.CanBeImmediate(value) ? g.UseImmediate(value) : g.UseRegister(value); 260 g.CanBeImmediate(value) ? g.UseImmediate(value) : g.UseRegister(value);
261 inputs[input_count++] = value_operand; 261 inputs[input_count++] = value_operand;
262 Emit(code, 0, static_cast<InstructionOperand*>(nullptr), input_count, 262 Emit(code, 0, static_cast<InstructionOperand*>(nullptr), input_count,
263 inputs); 263 inputs);
264 } 264 }
265 } 265 }
266 266
267 // Architecture supports unaliged access, therefore VisitLoad is used instead
268 void InstructionSelector::VisitUnalignedLoad(Node* node) { UNREACHABLE(); }
269
270 // Architecture supports unaliged access, therefore VisitStore is used instead
271 void InstructionSelector::VisitUnalignedStore(Node* node) { UNREACHABLE(); }
267 272
268 void InstructionSelector::VisitCheckedLoad(Node* node) { 273 void InstructionSelector::VisitCheckedLoad(Node* node) {
269 CheckedLoadRepresentation load_rep = CheckedLoadRepresentationOf(node->op()); 274 CheckedLoadRepresentation load_rep = CheckedLoadRepresentationOf(node->op());
270 X64OperandGenerator g(this); 275 X64OperandGenerator g(this);
271 Node* const buffer = node->InputAt(0); 276 Node* const buffer = node->InputAt(0);
272 Node* const offset = node->InputAt(1); 277 Node* const offset = node->InputAt(1);
273 Node* const length = node->InputAt(2); 278 Node* const length = node->InputAt(2);
274 ArchOpcode opcode = kArchNop; 279 ArchOpcode opcode = kArchNop;
275 switch (load_rep.representation()) { 280 switch (load_rep.representation()) {
276 case MachineRepresentation::kWord8: 281 case MachineRepresentation::kWord8:
(...skipping 1694 matching lines...) Expand 10 before | Expand all | Expand 10 after
1971 MachineOperatorBuilder::kFloat64RoundTruncate | 1976 MachineOperatorBuilder::kFloat64RoundTruncate |
1972 MachineOperatorBuilder::kFloat32RoundTiesEven | 1977 MachineOperatorBuilder::kFloat32RoundTiesEven |
1973 MachineOperatorBuilder::kFloat64RoundTiesEven; 1978 MachineOperatorBuilder::kFloat64RoundTiesEven;
1974 } 1979 }
1975 return flags; 1980 return flags;
1976 } 1981 }
1977 1982
1978 } // namespace compiler 1983 } // namespace compiler
1979 } // namespace internal 1984 } // namespace internal
1980 } // namespace v8 1985 } // namespace v8
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698