Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Side by Side Diff: src/compiler/ia32/instruction-selector-ia32.cc

Issue 1779713009: Implement optional turbofan UnalignedLoad and UnalignedStore operators (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix failures in cctest/test-run-wasm-64/Run_Wasm_LoadStoreI64_sx due to missing implementation of U… Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/base/adapters.h" 5 #include "src/base/adapters.h"
6 #include "src/compiler/instruction-selector-impl.h" 6 #include "src/compiler/instruction-selector-impl.h"
7 #include "src/compiler/node-matchers.h" 7 #include "src/compiler/node-matchers.h"
8 #include "src/compiler/node-properties.h" 8 #include "src/compiler/node-properties.h"
9 9
10 namespace v8 { 10 namespace v8 {
(...skipping 285 matching lines...) Expand 10 before | Expand all | Expand 10 after
296 AddressingMode addressing_mode = 296 AddressingMode addressing_mode =
297 g.GetEffectiveAddressMemoryOperand(node, inputs, &input_count); 297 g.GetEffectiveAddressMemoryOperand(node, inputs, &input_count);
298 InstructionCode code = 298 InstructionCode code =
299 opcode | AddressingModeField::encode(addressing_mode); 299 opcode | AddressingModeField::encode(addressing_mode);
300 inputs[input_count++] = val; 300 inputs[input_count++] = val;
301 Emit(code, 0, static_cast<InstructionOperand*>(nullptr), input_count, 301 Emit(code, 0, static_cast<InstructionOperand*>(nullptr), input_count,
302 inputs); 302 inputs);
303 } 303 }
304 } 304 }
305 305
306 // Architecture supports unaliged access, therefore VisitLoad is used instead
titzer 2016/03/22 15:00:20 s/unaliged/unaligned/ here and in other files
307 void InstructionSelector::VisitUnalignedLoad(Node* node) { UNREACHABLE(); }
308
309 // Architecture supports unaliged access, therefore VisitStore is used instead
310 void InstructionSelector::VisitUnalignedStore(Node* node) { UNREACHABLE(); }
306 311
307 void InstructionSelector::VisitCheckedLoad(Node* node) { 312 void InstructionSelector::VisitCheckedLoad(Node* node) {
308 CheckedLoadRepresentation load_rep = CheckedLoadRepresentationOf(node->op()); 313 CheckedLoadRepresentation load_rep = CheckedLoadRepresentationOf(node->op());
309 IA32OperandGenerator g(this); 314 IA32OperandGenerator g(this);
310 Node* const buffer = node->InputAt(0); 315 Node* const buffer = node->InputAt(0);
311 Node* const offset = node->InputAt(1); 316 Node* const offset = node->InputAt(1);
312 Node* const length = node->InputAt(2); 317 Node* const length = node->InputAt(2);
313 ArchOpcode opcode = kArchNop; 318 ArchOpcode opcode = kArchNop;
314 switch (load_rep.representation()) { 319 switch (load_rep.representation()) {
315 case MachineRepresentation::kWord8: 320 case MachineRepresentation::kWord8:
(...skipping 1225 matching lines...) Expand 10 before | Expand all | Expand 10 after
1541 MachineOperatorBuilder::kFloat64RoundTruncate | 1546 MachineOperatorBuilder::kFloat64RoundTruncate |
1542 MachineOperatorBuilder::kFloat32RoundTiesEven | 1547 MachineOperatorBuilder::kFloat32RoundTiesEven |
1543 MachineOperatorBuilder::kFloat64RoundTiesEven; 1548 MachineOperatorBuilder::kFloat64RoundTiesEven;
1544 } 1549 }
1545 return flags; 1550 return flags;
1546 } 1551 }
1547 1552
1548 } // namespace compiler 1553 } // namespace compiler
1549 } // namespace internal 1554 } // namespace internal
1550 } // namespace v8 1555 } // namespace v8
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698