Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Unified Diff: build/common.gypi

Issue 1779713003: Test warning suppression with VS 2015 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/config/compiler/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index e8042fea050ca0797c35939cf401baf0b2a6604e..eb486519e66329a969e783d548f980e7ca988e88 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -5628,11 +5628,13 @@
],
}],
],
+ # Add extra include directories here that need to be in front of the
+ # installed and packaged include directories. This may be needed in
+ # order to force a particular SDK version, such as to get VS 2013 to use
+ # the Windows 10 SDK. Beware of making the INCLUDE variable excessively
+ # long, and be sure to make corresponding changes to
+ # build\toolchain\win\setup_toolchain.py
'msvs_system_include_dirs': [
- '<(windows_sdk_path)/Include/10.0.10586.0/shared',
- '<(windows_sdk_path)/Include/10.0.10586.0/um',
- '<(windows_sdk_path)/Include/10.0.10586.0/winrt',
- '$(VSInstallDir)/VC/atlmfc/include',
],
'msvs_cygwin_shell': 0,
'msvs_disabled_warnings': [
@@ -5711,6 +5713,11 @@
# TODO(brucedawson): http://crbug.com/554200 4312 is a VS
# 2015 64-bit warning for integer to larger pointer
4312,
+
+ # TODO(brucedawson): http://crbug.com/593448 4334 is a 'suspicious
+ # shift' warning and 4595 is an 'illegal inline operator new' warning
+ # Both are new in VS 2015 Update 2 and can safely be deferred for now.
+ 4334, 4595,
],
'msvs_settings': {
'VCCLCompilerTool': {
« no previous file with comments | « no previous file | build/config/compiler/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698