Issue 1779703003: Add a pixel test for text rendering regression

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1779703003: Add a pixel test for text rendering regression (Closed)

Created:
4 years, 9 months ago by Wei Li

Modified:
4 years, 9 months ago

Reviewers:
Tom Sepez

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Add a pixel test for text rendering regression Code committed at 258f19f makes the test pass. BUG=591137 R=tsepez@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/520f247443253356b0ce236066fce95e7fad7680

Created: 4 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -0 lines)			Patch
	A	testing/resources/pixel/bug_591137.in	View		Binary file		0 comments	Download
	A	testing/resources/pixel/bug_591137_expected.pdf.0.png	View		Binary file		0 comments	Download

Total messages: 5 (2 generated)

Wei Li

Now use a small pixel test instead. Deleted the other CL. PTAL, thanks.

4 years, 9 months ago (2016-03-10 00:02:05 UTC) #2

Tom Sepez

RS LGTM, though I can't say for sure because reitveld won't show me the binary ...

4 years, 9 months ago (2016-03-10 00:28:33 UTC) #3

Wei Li

4 years, 9 months ago (2016-03-10 01:24:43 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
520f247443253356b0ce236066fce95e7fad7680 (presubmit successful).