 Chromium Code Reviews
 Chromium Code Reviews Issue 1779673003:
  Added network components for blimp text input feature  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/src.git@master
    
  
    Issue 1779673003:
  Added network components for blimp text input feature  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/src.git@master| Index: blimp/client/app/android/web_input_box.h | 
| diff --git a/blimp/client/app/android/web_input_box.h b/blimp/client/app/android/web_input_box.h | 
| index 4166b1a40a3c5c35de5964f6811205edfcaed27e..b38e96d29dff123433f947feecb3802c27d1913c 100644 | 
| --- a/blimp/client/app/android/web_input_box.h | 
| +++ b/blimp/client/app/android/web_input_box.h | 
| @@ -9,19 +9,27 @@ | 
| #include "base/android/jni_android.h" | 
| #include "base/macros.h" | 
| +#include "blimp/client/feature/ime_feature.h" | 
| +#include "ui/base/ime/text_input_type.h" | 
| namespace blimp { | 
| namespace client { | 
| // The native component of org.chromium.blimp.input.WebInputBox. | 
| -class WebInputBox { | 
| +class WebInputBox : public ImeFeature::ImeFeatureDelegate { | 
| public: | 
| static bool RegisterJni(JNIEnv* env); | 
| - WebInputBox(JNIEnv* env, const base::android::JavaParamRef<jobject>& jobj); | 
| + WebInputBox(JNIEnv* env, | 
| + const base::android::JavaParamRef<jobject>& jobj, | 
| + ImeFeature* ime_feature); | 
| 
Wez
2016/03/18 20:51:27
nit: Need a comment to clarify the lifetime expect
 
shaktisahu
2016/03/22 19:44:19
Comments added to the header file.
 
shaktisahu
2016/03/22 19:44:19
Acknowledged.
 | 
| - // Brings up or hides the IME for user to enter text. | 
| - void OnImeRequested(bool show); | 
| + // Brings up IME for user to enter text. | 
| + void OnShowImeRequested(ui::TextInputType input_type, | 
| + const std::string& text) override; | 
| + | 
| + // Hides IME. | 
| + void OnHideImeRequested() override; | 
| // Methods called from Java via JNI. | 
| void Destroy(JNIEnv* env, const base::android::JavaParamRef<jobject>& jobj); | 
| @@ -37,6 +45,10 @@ class WebInputBox { | 
| // Reference to the Java object which owns this class. | 
| base::android::ScopedJavaGlobalRef<jobject> java_obj_; | 
| + // A bridge to the network layer which does the work of (de)serializing the | 
| + // outgoing and incoming BlimpMessage::IME messages from the engine. | 
| + ImeFeature* ime_feature_; | 
| + | 
| DISALLOW_COPY_AND_ASSIGN(WebInputBox); | 
| }; |