blimp/client/app/android/blimp_compositor_manager_android.h - Issue 1779673003: Added network components for blimp text input feature

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: blimp/client/app/android/blimp_compositor_manager_android.h

Issue 1779673003: Added network components for blimp text input feature (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added unit tests and addressed comments Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « blimp/client/DEPS ('k') | blimp/client/app/android/java/src/org/chromium/blimp/input/WebInputBox.java » ('j') | blimp/client/app/android/web_input_box.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: blimp/client/app/android/blimp_compositor_manager_android.h

diff --git a/blimp/client/app/android/blimp_compositor_manager_android.h b/blimp/client/app/android/blimp_compositor_manager_android.h

index f744ede9d7a5fd65f190736336466a2887d736a7..c1b94f4dade5dc6a319850d2b32ccdd5858725cf 100644

--- a/blimp/client/app/android/blimp_compositor_manager_android.h

+++ b/blimp/client/app/android/blimp_compositor_manager_android.h

@@ -49,7 +49,7 @@ class BlimpCompositorManagerAndroid : public BlimpCompositorManager {

RenderWidgetFeature* render_widget_feature);

// BlimpCompositor implementation.

- void GenerateLayerTreeSettings(cc::LayerTreeSettings* settings);

+ void GenerateLayerTreeSettings(cc::LayerTreeSettings* settings) override;

Wez 2016/03/18 20:51:27 nit: Is this inherited from some other CL..?

shaktisahu 2016/03/22 19:44:19 Yes. It is related to Khushal's another change whi

private:

// Used to determine tile size for the compositor's rastered tiles. For a