 Chromium Code Reviews
 Chromium Code Reviews Issue 1779673003:
  Added network components for blimp text input feature  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/src.git@master
    
  
    Issue 1779673003:
  Added network components for blimp text input feature  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/src.git@master| Index: blimp/engine/feature/engine_render_widget_feature.h | 
| diff --git a/blimp/engine/feature/engine_render_widget_feature.h b/blimp/engine/feature/engine_render_widget_feature.h | 
| index 155ad3e538a95ed1fbe1e10edaa8d232c94f833c..20d0f7cd3a37548440242d924121086b4fb28170 100644 | 
| --- a/blimp/engine/feature/engine_render_widget_feature.h | 
| +++ b/blimp/engine/feature/engine_render_widget_feature.h | 
| @@ -16,6 +16,7 @@ | 
| #include "base/memory/scoped_ptr.h" | 
| #include "blimp/net/blimp_message_processor.h" | 
| #include "blimp/net/input_message_converter.h" | 
| +#include "ui/base/ime/text_input_client.h" | 
| namespace blink { | 
| class WebGestureEvent; | 
| @@ -63,6 +64,9 @@ class EngineRenderWidgetFeature : public BlimpMessageProcessor { | 
| void set_compositor_message_sender( | 
| scoped_ptr<BlimpMessageProcessor> message_processor); | 
| + void set_ime_message_sender( | 
| + scoped_ptr<BlimpMessageProcessor> message_processor); | 
| + | 
| // Notifes the client that a new RenderWidget for a particular WebContents has | 
| // been created. This will trigger the creation of the BlimpCompositor for | 
| // this widget on the client. | 
| @@ -83,6 +87,14 @@ class EngineRenderWidgetFeature : public BlimpMessageProcessor { | 
| void OnRenderWidgetDeleted(const int tab_id, | 
| content::RenderWidgetHost* render_widget_host); | 
| + // Sends an ImeMessage to show/hide IME. | 
| 
haibinlu
2016/03/17 18:59:46
Notifies the client to show/hide IME.
 
shaktisahu
2016/03/18 19:08:06
Done.
 
shaktisahu
2016/03/18 19:08:06
Done.
 | 
| + void SendShowImeRequest(const int tab_id, | 
| + content::RenderWidgetHost* render_widget_host, | 
| + const ui::TextInputClient* client); | 
| + void SendHideImeRequest(const int tab_id, | 
| + content::RenderWidgetHost* render_widget_host, | 
| + const ui::TextInputClient* client); | 
| 
David Trainor- moved to gerrit
2016/03/17 21:53:29
Do we need the client for hide?
 | 
| + | 
| // Sends a CompositorMessage for |tab_id| to the client. | 
| void SendCompositorMessage(const int tab_id, | 
| content::RenderWidgetHost* render_widget_host, | 
| @@ -134,6 +146,8 @@ class EngineRenderWidgetFeature : public BlimpMessageProcessor { | 
| content::RenderWidgetHost* GetRenderWidgetHost(const int tab_id, | 
| const int render_widget_id); | 
| + void InsertTextFromIME(ui::TextInputClient* client, std::string text); | 
| 
haibinlu
2016/03/17 18:59:46
add method document
 
shaktisahu
2016/03/18 19:08:06
Done.
 
shaktisahu
2016/03/18 19:08:06
Done.
 | 
| + | 
| DelegateMap delegates_; | 
| TabMap tabs_; | 
| @@ -155,6 +169,7 @@ class EngineRenderWidgetFeature : public BlimpMessageProcessor { | 
| scoped_ptr<BlimpMessageProcessor> render_widget_message_sender_; | 
| scoped_ptr<BlimpMessageProcessor> compositor_message_sender_; | 
| scoped_ptr<BlimpMessageProcessor> input_message_sender_; | 
| + scoped_ptr<BlimpMessageProcessor> ime_message_sender_; | 
| DISALLOW_COPY_AND_ASSIGN(EngineRenderWidgetFeature); | 
| }; |