Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2331)

Unified Diff: blimp/engine/session/blimp_engine_session.h

Issue 1779673003: Added network components for blimp text input feature (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: blimp/engine/session/blimp_engine_session.h
diff --git a/blimp/engine/session/blimp_engine_session.h b/blimp/engine/session/blimp_engine_session.h
index ae527e5fcd7eb87f53a38a28ac05ec7d6fe3b7b4..bbb7dbd9f889945f660b89f3970980036b727d27 100644
--- a/blimp/engine/session/blimp_engine_session.h
+++ b/blimp/engine/session/blimp_engine_session.h
@@ -19,6 +19,7 @@
#include "content/public/browser/web_contents_delegate.h"
#include "content/public/browser/web_contents_observer.h"
#include "net/base/completion_callback.h"
+#include "ui/base/ime/input_method_observer.h"
#include "ui/gfx/geometry/size.h"
namespace aura {
@@ -69,6 +70,7 @@ class BlimpEngineSession
: public BlimpMessageProcessor,
public content::WebContentsDelegate,
public content::WebContentsObserver,
+ public ui::InputMethodObserver,
public EngineRenderWidgetFeature::RenderWidgetMessageDelegate {
public:
BlimpEngineSession(scoped_ptr<BlimpBrowserContext> browser_context,
@@ -137,6 +139,18 @@ class BlimpEngineSession
void NavigationStateChanged(content::WebContents* source,
content::InvalidateTypes changed_flags) override;
+ // ui::InputMethodObserver overrides.
nyquist 2016/03/10 00:57:13 Could this either move to the EngineRenderWidgetFe
+ void OnTextInputTypeChanged(const ui::TextInputClient* client) override;
+ void OnFocus() override;
+ void OnBlur() override;
+ void OnCaretBoundsChanged(const ui::TextInputClient* client) override;
+ void OnTextInputStateChanged(const ui::TextInputClient* client) override;
+ void OnInputMethodDestroyed(const ui::InputMethod* input_method) override;
+ void OnShowImeIfNeeded() override;
+
+ // Used to show/hide IME when user selects text input.
+ void ShowIme(bool show);
nyquist 2016/03/10 00:57:13 Can this be private?
+
// content::WebContentsObserver implementation.
void RenderViewCreated(content::RenderViewHost* render_view_host) override;
void RenderViewHostChanged(content::RenderViewHost* old_host,
@@ -186,6 +200,7 @@ class BlimpEngineSession
// Used to send TAB_CONTROL or NAVIGATION messages to client.
scoped_ptr<BlimpMessageProcessor> tab_control_message_sender_;
scoped_ptr<BlimpMessageProcessor> navigation_message_sender_;
+ scoped_ptr<BlimpMessageProcessor> ime_message_sender_;
DISALLOW_COPY_AND_ASSIGN(BlimpEngineSession);
};

Powered by Google App Engine
This is Rietveld 408576698