Added network components for blimp text input feature

blimp/client/app/android/web_input_box.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/android/jni_string.h"
 #include "blimp/client/app/android/blimp_client_session_android.h"
 #include "blimp/client/app/android/web_input_box.h"
+#include "blimp/client/feature/ime_feature.h"
 #include "jni/WebInputBox_jni.h"
+#include "ui/base/ime/text_input_type.h"
 
 namespace blimp {
 namespace client {
 
 static jlong Init(JNIEnv* env,
                   const JavaParamRef<jobject>& jobj,
                   const JavaParamRef<jobject>& blimp_client_session) {
-  return reinterpret_cast<intptr_t>(new WebInputBox(env, jobj));
+  BlimpClientSession* client_session =
+      BlimpClientSessionAndroid::FromJavaObject(env,
+                                                blimp_client_session.obj());
+  return reinterpret_cast<intptr_t>(

[Wez, 2016/03/18 20:51:27]

Why are you reinterpret_cast<>ing to intptr_t rather than to jlong, since that
is the return type you actually need?

[shaktisahu, 2016/03/22 19:44:19]

reinterpret_cast to intptr_t is quite standard in JNI and is used in many places
in the code. I am not sure of the reason, but apparently complier might give a
warning on 32 bit machines if jlong is used instead.

[Wez, 2016/03/22 21:43:37]

Huh... apparently it's about ensuring that the conversion is well-defined (since
you're going from an effectively unsigned 32- or 64-bit pointer to a signed
64-bit value - in the 32-bit case I think it can be ambiguous whether to cast to
signed and then sign-extend to 64-bit, versus extend to 64-bit and then switch
to signed.

WebRTC has a nice helper for this with a helpful comment; shame Chromium
doesn't. :(

Anyway... Ack!

+      new WebInputBox(env, jobj, client_session->GetImeFeature()));
 }
 
 // static
 bool WebInputBox::RegisterJni(JNIEnv* env) {
   return RegisterNativesImpl(env);
 }
 
 WebInputBox::WebInputBox(JNIEnv* env,
-                         const base::android::JavaParamRef<jobject>& jobj) {
+                         const base::android::JavaParamRef<jobject>& jobj,
+                         ImeFeature* ime_feature) {
   java_obj_.Reset(env, jobj);
+  ime_feature_ = ime_feature;
+  ime_feature_->SetDelegate(this);
 }
 
-WebInputBox::~WebInputBox() {}
+WebInputBox::~WebInputBox() {
+  ime_feature_->SetDelegate(nullptr);
+}
 
 void WebInputBox::Destroy(JNIEnv* env, const JavaParamRef<jobject>& jobj) {
   delete this;
 }
 
-void WebInputBox::OnImeRequested(bool show) {
+void WebInputBox::OnShowImeRequested(ui::TextInputType input_type,
+                                     const std::string& text) {
   JNIEnv* env = base::android::AttachCurrentThread();
-  Java_WebInputBox_onImeRequested(env, java_obj_.obj(), show);
+  Java_WebInputBox_onShowImeRequested(
+      env, java_obj_.obj(), input_type,

[Wez, 2016/03/18 20:51:27]

nit: It looks a little strange to have |env| need to be supplied to the ctor,
but then grabbed implicitly from the thread here - AFAICT the |env| is always
per-thread, so can we avoid needing to pass it to the ctor at all..?

Similarly, it is strange for OnShowImeRequested() to grab the |env| implicitly
while OnImeTestEntered() requires it to be passed explicitly.

[shaktisahu, 2016/03/22 19:44:19]

OnShowImeRequested() is a native-to-Java call whereas OnImeTextEntered() is a
Java-to-native call. This is similar to the way most of the other native-to-Java
calls in the other feature implementations.

[Wez, 2016/03/22 21:43:37]

Acknowledged.

+      base::android::ConvertUTF8ToJavaString(env, text).obj());
+}
+
+void WebInputBox::OnHideImeRequested() {
+  JNIEnv* env = base::android::AttachCurrentThread();
+  Java_WebInputBox_onHideImeRequested(env, java_obj_.obj());
 }
 
 void WebInputBox::OnImeTextEntered(JNIEnv* env,
                                    const JavaParamRef<jobject>& jobj,
                                    const JavaParamRef<jstring>& text) {
-  // TODO(shaktisahu): Send text to browser.
+  std::string textInput = base::android::ConvertJavaStringToUTF8(env, text);
+  ime_feature_->SendImeTextToEngine(textInput);
 }
 
 }  // namespace client
 }  // namespace blimp