blimp/common/proto/blimp_conversions.h - Issue 1779673003: Added network components for blimp text input feature

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: blimp/common/proto/blimp_conversions.h

Issue 1779673003: Added network components for blimp text input feature (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added proto coverters for TextInputType Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef BLIMP_COMMON_PROTO_BLIMP_CONVERSIONS_H_
	haibinlu 2016/03/17 18:59:46 we have a blimp/net/input_message_converter.h. Can we have a blimp/net/input_message_converter.h. Can this be merged into that file? If a separate file is needed, name it text_input_type_converter instead of a generic blimp_conversion. shaktisahu 2016/03/18 19:08:06 Done. Show quoted text On 2016/03/17 18:59:46, haibinlu wrote: > we have a blimp/net/input_message_converter.h. Can this be merged into that > file? If a separate file is needed, name it text_input_type_converter instead of > a generic blimp_conversion. Done.
	6 #define BLIMP_COMMON_PROTO_BLIMP_CONVERSIONS_H_

	7

	8 #include "blimp/common/blimp_common_export.h"

	9 #include "blimp/common/proto/ime.pb.h"

	10 #include "ui/base/ime/text_input_type.h"

	11

	12 namespace blimp {

	13

	14 BLIMP_COMMON_EXPORT ui::TextInputType TextInputTypeFromProto(
	Khushal 2016/03/17 10:02:45 Could you add unit tests for these? You can take a Could you add unit tests for these? You can take a look at the cc code for examples of tests for such conversions. shaktisahu 2016/03/18 19:08:05 Done. Show quoted text On 2016/03/17 10:02:45, Khushal wrote: > Could you add unit tests for these? You can take a look at the cc code for > examples of tests for such conversions. Done.
	15 ImeMessage_InputType type);

	16

	17 BLIMP_COMMON_EXPORT ImeMessage_InputType

	18 TextInputTypeToProto(ui::TextInputType type);

	19

	20 } // namespace blimp

	21

	22 #endif // BLIMP_COMMON_PROTO_BLIMP_CONVERSIONS_H_

OLD	NEW

« blimp/client/feature/web_input_feature.cc ('K') | « blimp/common/proto/BUILD.gn ('k') | blimp/common/proto/blimp_conversions.cc » ('j') | blimp/common/proto/blimp_conversions.cc » ('J')