extensions/browser/api/networking_private/networking_private_chromeos.cc - Issue 1779633002: Invoke createNetwork() callback with GUID, not service name

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/networking_private/networking_private_chromeos.cc

Issue 1779633002: Invoke createNetwork() callback with GUID, not service name (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix more trybot failures Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/wifi_sync/wifi_config_delegate_chromeos_unittest.cc ('k') | extensions/browser/api/vpn_provider/vpn_service.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/networking_private/networking_private_chromeos.cc

diff --git a/extensions/browser/api/networking_private/networking_private_chromeos.cc b/extensions/browser/api/networking_private/networking_private_chromeos.cc

index 5754f373c26d285dc08f8e256e52e3c74105b2fd..a7108488a2a3df227b8f4cad8843cde4bb820118 100644

--- a/extensions/browser/api/networking_private/networking_private_chromeos.cc

+++ b/extensions/browser/api/networking_private/networking_private_chromeos.cc

@@ -302,6 +302,13 @@ void NetworkingPrivateChromeOS::SetProperties(

base::Bind(&NetworkHandlerFailureCallback, failure_callback));

}

+void NetworkHandlerCreateCallback(

+ const NetworkingPrivateDelegate::StringCallback& callback,

+ const std::string& service_path,

+ const std::string& guid) {

+ callback.Run(guid);

void NetworkingPrivateChromeOS::CreateNetwork(

bool shared,

scoped_ptr<base::DictionaryValue> properties,

@@ -316,7 +323,8 @@ void NetworkingPrivateChromeOS::CreateNetwork(

}

GetManagedConfigurationHandler()->CreateConfiguration(

- user_id_hash, *properties, success_callback,

+ user_id_hash, *properties,

+ base::Bind(&NetworkHandlerCreateCallback, success_callback),

base::Bind(&NetworkHandlerFailureCallback, failure_callback));

}