chrome/browser/sync/test/integration/wifi_credentials_helper_chromeos.cc - Issue 1779633002: Invoke createNetwork() callback with GUID, not service name

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/test/integration/wifi_credentials_helper_chromeos.cc

Issue 1779633002: Invoke createNetwork() callback with GUID, not service name (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix more trybot failures Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/vpn_provider/vpn_provider_apitest.cc ('k') | chromeos/network/managed_network_configuration_handler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync/test/integration/wifi_credentials_helper_chromeos.cc

diff --git a/chrome/browser/sync/test/integration/wifi_credentials_helper_chromeos.cc b/chrome/browser/sync/test/integration/wifi_credentials_helper_chromeos.cc

index 7117f198d8d1f7aeacf97aea03ba428de64db72c..6f7e3a6a28c9bb064ba996b4975099bc7b70dca6 100644

--- a/chrome/browser/sync/test/integration/wifi_credentials_helper_chromeos.cc

+++ b/chrome/browser/sync/test/integration/wifi_credentials_helper_chromeos.cc

@@ -106,14 +106,12 @@ void AddWifiCredentialToProfileChromeOs(

credential.ToOncProperties();

CHECK(onc_properties) << "Failed to generate ONC properties for "

<< credential.ToString();

- GetManagedNetworkConfigurationHandler()

- ->CreateConfiguration(

- ChromeOsUserHashForBrowserContext(*browser_context),

- *onc_properties,

- ::chromeos::network_handler::StringResultCallback(),

- base::Bind(LogCreateConfigurationFailure,

- base::StringPrintf("Failed to add credential %s",

- credential.ToString().c_str())));

+ GetManagedNetworkConfigurationHandler()->CreateConfiguration(

+ ChromeOsUserHashForBrowserContext(*browser_context), *onc_properties,

+ ::chromeos::network_handler::ServiceResultCallback(),

+ base::Bind(LogCreateConfigurationFailure,

+ base::StringPrintf("Failed to add credential %s",

+ credential.ToString().c_str())));

base::MessageLoop::current()->RunUntilIdle();

}