components/wifi_sync/wifi_config_delegate_chromeos.cc - Issue 1779633002: Invoke createNetwork() callback with GUID, not service name

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/wifi_sync/wifi_config_delegate_chromeos.cc

Issue 1779633002: Invoke createNetwork() callback with GUID, not service name (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: pass both service_path and guid arguments to all callbacks Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chromeos/network/network_handler_callbacks.h ('k') | extensions/browser/api/networking_private/networking_private_api.h » ('j') | extensions/browser/api/networking_private/networking_private_chromeos.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/wifi_sync/wifi_config_delegate_chromeos.cc

diff --git a/components/wifi_sync/wifi_config_delegate_chromeos.cc b/components/wifi_sync/wifi_config_delegate_chromeos.cc

index d8d241fc17c885c947fd48ec79e117dfed44c05a..780dd1e04baaf6e0ad8375f0f02e9dda10f53ca6 100644

--- a/components/wifi_sync/wifi_config_delegate_chromeos.cc

+++ b/components/wifi_sync/wifi_config_delegate_chromeos.cc

@@ -50,12 +50,10 @@ void WifiConfigDelegateChromeOs::AddToLocalNetworks(

return;

}

- managed_network_configuration_handler_

- ->CreateConfiguration(

- user_hash_,

- *onc_properties,

- chromeos::network_handler::StringResultCallback(),

- base::Bind(OnCreateConfigurationFailed, network_credential));

+ managed_network_configuration_handler_->CreateConfiguration(

+ user_hash_, *onc_properties,

+ chromeos::network_handler::ServiceResultCallback(),

+ base::Bind(OnCreateConfigurationFailed, network_credential));

}

} // namespace wifi_sync