chromeos/network/managed_network_configuration_handler_impl.h - Issue 1779633002: Invoke createNetwork() callback with GUID, not service name

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromeos/network/managed_network_configuration_handler_impl.h

Issue 1779633002: Invoke createNetwork() callback with GUID, not service name (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: pass both service_path and guid arguments to all callbacks Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chromeos/network/managed_network_configuration_handler.h ('k') | chromeos/network/managed_network_configuration_handler_impl.cc » ('j') | extensions/browser/api/networking_private/networking_private_chromeos.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chromeos/network/managed_network_configuration_handler_impl.h

diff --git a/chromeos/network/managed_network_configuration_handler_impl.h b/chromeos/network/managed_network_configuration_handler_impl.h

index a6337f3d859313b3bfeee4970188fa333e34cbd3..c94e446729e867d032efb34bc94793c437245041 100644

--- a/chromeos/network/managed_network_configuration_handler_impl.h

+++ b/chromeos/network/managed_network_configuration_handler_impl.h

@@ -62,7 +62,7 @@ class CHROMEOS_EXPORT ManagedNetworkConfigurationHandlerImpl

void CreateConfiguration(

const std::string& userhash,

const base::DictionaryValue& properties,

- const network_handler::StringResultCallback& callback,

+ const network_handler::ServiceResultCallback& callback,

const network_handler::ErrorCallback& error_callback) const override;

void RemoveConfiguration(

@@ -152,7 +152,8 @@ class CHROMEOS_EXPORT ManagedNetworkConfigurationHandlerImpl

const Policies* GetPoliciesForUser(const std::string& userhash) const;

const Policies* GetPoliciesForProfile(const NetworkProfile& profile) const;

- void OnPolicyAppliedToNetwork(const std::string& service_path);

+ void OnPolicyAppliedToNetwork(const std::string& service_path,

+ const std::string& guid);

// Helper method to append associated Device properties to |properties|.

void GetDeviceStateProperties(const std::string& service_path,