chrome/browser/chromeos/net/onc_utils.cc - Issue 1779633002: Invoke createNetwork() callback with GUID, not service name

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/net/onc_utils.cc

Issue 1779633002: Invoke createNetwork() callback with GUID, not service name (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: pass both service_path and guid arguments to all callbacks Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/login/helper.cc ('k') | chrome/browser/sync/test/integration/wifi_credentials_helper_chromeos.cc » ('j') | extensions/browser/api/networking_private/networking_private_chromeos.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/net/onc_utils.cc

diff --git a/chrome/browser/chromeos/net/onc_utils.cc b/chrome/browser/chromeos/net/onc_utils.cc

index 36c5df80b52d45369ca099dffa95bc9413a2ef3d..22bec7033826470fa8e582a25c969db7bd1c9d40 100644

--- a/chrome/browser/chromeos/net/onc_utils.cc

+++ b/chrome/browser/chromeos/net/onc_utils.cc

@@ -141,7 +141,7 @@ void ImportNetworksForUser(const user_manager::User* user,

} else {

config_handler->CreateShillConfiguration(

*shill_dict, NetworkConfigurationObserver::SOURCE_USER_ACTION,

- network_handler::StringResultCallback(),

+ network_handler::ServiceResultCallback(),

network_handler::ErrorCallback());

}