Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Side by Side Diff: extensions/browser/api/networking_private/networking_private_linux.cc

Issue 1779633002: Invoke createNetwork() callback with GUID, not service name (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: pass both service_path and guid arguments to all callbacks Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "extensions/browser/api/networking_private/networking_private_linux.h" 5 #include "extensions/browser/api/networking_private/networking_private_linux.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/bind_helpers.h" 10 #include "base/bind_helpers.h"
(...skipping 246 matching lines...) Expand 10 before | Expand all | Expand 10 after
257 const std::string& guid, 257 const std::string& guid,
258 scoped_ptr<base::DictionaryValue> properties, 258 scoped_ptr<base::DictionaryValue> properties,
259 const VoidCallback& success_callback, 259 const VoidCallback& success_callback,
260 const FailureCallback& failure_callback) { 260 const FailureCallback& failure_callback) {
261 ReportNotSupported("SetProperties", failure_callback); 261 ReportNotSupported("SetProperties", failure_callback);
262 } 262 }
263 263
264 void NetworkingPrivateLinux::CreateNetwork( 264 void NetworkingPrivateLinux::CreateNetwork(
265 bool shared, 265 bool shared,
266 scoped_ptr<base::DictionaryValue> properties, 266 scoped_ptr<base::DictionaryValue> properties,
267 const StringCallback& success_callback, 267 const ServiceCallback& success_callback,
268 const FailureCallback& failure_callback) { 268 const FailureCallback& failure_callback) {
269 ReportNotSupported("CreateNetwork", failure_callback); 269 ReportNotSupported("CreateNetwork", failure_callback);
270 } 270 }
271 271
272 void NetworkingPrivateLinux::ForgetNetwork( 272 void NetworkingPrivateLinux::ForgetNetwork(
273 const std::string& guid, 273 const std::string& guid,
274 const VoidCallback& success_callback, 274 const VoidCallback& success_callback,
275 const FailureCallback& failure_callback) { 275 const FailureCallback& failure_callback) {
276 // TODO(zentaro): Implement for Linux. 276 // TODO(zentaro): Implement for Linux.
277 ReportNotSupported("ForgetNetwork", failure_callback); 277 ReportNotSupported("ForgetNetwork", failure_callback);
(...skipping 920 matching lines...) Expand 10 before | Expand all | Expand 10 after
1198 base::Unretained(this), base::Passed(&guid_list))); 1198 base::Unretained(this), base::Passed(&guid_list)));
1199 } 1199 }
1200 1200
1201 void NetworkingPrivateLinux::OnNetworksChangedEventTask( 1201 void NetworkingPrivateLinux::OnNetworksChangedEventTask(
1202 scoped_ptr<GuidList> guid_list) { 1202 scoped_ptr<GuidList> guid_list) {
1203 DCHECK_CURRENTLY_ON(content::BrowserThread::UI); 1203 DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
1204 OnNetworksChangedEventOnUIThread(*guid_list); 1204 OnNetworksChangedEventOnUIThread(*guid_list);
1205 } 1205 }
1206 1206
1207 } // namespace extensions 1207 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698