Invoke createNetwork() callback with GUID, not service name

extensions/browser/api/networking_private/networking_private_chromeos.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/browser/api/networking_private/networking_private_chromeos.h"
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/callback.h"
 #include "base/logging.h"
@@ skipping 287 matching lines @@
   }
 
   GetManagedConfigurationHandler()->SetProperties(
       service_path, *properties, success_callback,
       base::Bind(&NetworkHandlerFailureCallback, failure_callback));
 }
 
 void NetworkingPrivateChromeOS::CreateNetwork(
     bool shared,
     scoped_ptr<base::DictionaryValue> properties,
-    const StringCallback& success_callback,
+    const ServiceCallback& success_callback,
     const FailureCallback& failure_callback) {
   std::string user_id_hash, error;
   // Do not allow configuring a non-shared network from a non-primary user.
   if (!shared &&
       !GetPrimaryUserIdHash(browser_context_, &user_id_hash, &error)) {
     failure_callback.Run(error);
     return;
   }
 
   GetManagedConfigurationHandler()->CreateConfiguration(
       user_id_hash, *properties, success_callback,

[stevenjb, 2016/03/10 01:49:10]

By passing |success_callback| here directly, we are imposing the Chrome OS
implementation detail to the extension API. Instead we should create a local
wrapper function that passes just |guid| from the CreateConfiguration() callback
to |success_callback| (which should continue to just take a guid). Does that
make sense?

[Kevin Cernekee, 2016/03/11 01:53:57]

Done.

       base::Bind(&NetworkHandlerFailureCallback, failure_callback));
 }
 
 void NetworkingPrivateChromeOS::ForgetNetwork(
     const std::string& guid,
     const VoidCallback& success_callback,
     const FailureCallback& failure_callback) {
   std::string service_path, error;
   if (!GetServicePathFromGuid(guid, &service_path, &error)) {
     failure_callback.Run(error);
@@ skipping 327 matching lines @@
   // Eventually the caller (e.g. Settings) should handle any failures and
   // show its own configuration UI. crbug.com/380937.
   if (ui_delegate()->HandleConnectFailed(guid, error_name)) {
     success_callback.Run();
     return;
   }
   failure_callback.Run(error_name);
 }
 
 }  // namespace extensions