ARM Skia NEON patches - 25 - S32A_D565_Opaque_Dither clean/bugfix/speed

ARM Skia NEON patches - 25 - S32A_D565_Opaque_Dither clean/bugfix/speed

BlitRow565: S32A_D565_Opaque_Dither: some improvements

    - Supports ARGB and ABGR
    - Less magic numbers
    - Reduced instruction count : 5-25% speedup
    - Fixed indentation, removed some commented and useless code

Signed-off-by: Kévin PETIT <kevin.petit@arm.com>;

BUG=skia:

Committed: http://code.google.com/p/skia/source/detail?r=13577

[kevin.petit, 2014-02-24 16:12:04]

This fixes the code when SkPMColor is ARGB, hence the scary number of
rebaselines. As you don't currently have a bot testing NEON/ARGB I expect the
actual number to be much lower.

[djsollen, 2014-02-24 16:36:21]

https://codereview.chromium.org/177963003/diff/30001/expectations/gm/ignored-...
File expectations/gm/ignored-tests.txt (right):

https://codereview.chromium.org/177963003/diff/30001/expectations/gm/ignored-...
expectations/gm/ignored-tests.txt:68: # Added by kevin.petit@arm.com for
https://codereview.chromium.org/177963003/
since we don't have a ABRG bot why do we need this?  Do you expect your change
to alter the ARGB behavior as well?

[kevin.petit, 2014-02-24 16:42:16]

https://codereview.chromium.org/177963003/diff/30001/expectations/gm/ignored-...
File expectations/gm/ignored-tests.txt (right):

https://codereview.chromium.org/177963003/diff/30001/expectations/gm/ignored-...
expectations/gm/ignored-tests.txt:68: # Added by kevin.petit@arm.com for
https://codereview.chromium.org/177963003/
On 2014/02/24 16:36:21, djsollen wrote:
> since we don't have a ABRG bot why do we need this?  Do you expect your change
> to alter the ARGB behavior as well?

Yes, I've made small changes and the patched function is slightly faster and
gives exact results. The patch also makes the code a bit more readable.

[djsollen, 2014-02-24 20:23:11]

lgtm pending trybot run

[kevin.petit, 2014-02-25 10:38:29]

The CQ bit was checked by kevin.petit@arm.com

[commit-bot: I haz the power, 2014-02-25 10:38:40]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/kevin.petit@arm.com/177963003/30001

[commit-bot: I haz the power, 2014-02-25 10:54:36]

Change committed as 13577