Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 1779623002: Roll src/third_party/skia/ 8103a3430..042f859c1 (1 commit). (Closed)

Created:
4 years, 9 months ago by skia-deps-roller
Modified:
4 years, 9 months ago
CC:
bsalomon, bungeman-skia, chromium-reviews, reed1, robertphillips
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll src/third_party/skia/ 8103a3430..042f859c1 (1 commit). https://chromium.googlesource.com/skia.git/+log/8103a34300c5..042f859c19f7 $ git log 8103a3430..042f859c1 --date=short --no-merges --format='%ad %ae %s' 2016-03-08 kulshin Initialize the font fallback when the direct write font manager is created. CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel TBR=robertphillips@google.com Committed: https://crrev.com/e8cb0a5872250fc3845c0fbe7e49c88888301c71 Cr-Commit-Position: refs/heads/master@{#380046}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
skia-deps-roller
4 years, 9 months ago (2016-03-09 01:36:01 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1779623002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1779623002/1
4 years, 9 months ago (2016-03-09 01:36:43 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-09 02:57:43 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/e8cb0a5872250fc3845c0fbe7e49c88888301c71 Cr-Commit-Position: refs/heads/master@{#380046}
4 years, 9 months ago (2016-03-09 02:59:06 UTC) #6
Nico
4 years, 9 months ago (2016-03-09 18:50:39 UTC) #8
Message was sent while issue was closed.
This broke clang/win builds:

..\..\third_party\skia\src\ports\SkFontMgr_win_dw.cpp(272,11) :  error: field
'fLocaleName' will be initialized after field 'fFontFallback'
[-Werror,-Wreorder]
        , fLocaleName(localeNameLength)
          ^
1 error generated.

Please quickly take a look, or roll skia back a few revisions until this is
fixed.

Powered by Google App Engine
This is Rietveld 408576698