Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 1779523002: [flags] adding --trace_for_in_enumerate (Closed)

Created:
4 years, 9 months ago by Camillo Bruni
Modified:
4 years, 9 months ago
Reviewers:
Toon Verwaest
CC:
Michael Hablich, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[flags] adding --trace_for_in_enumerate With the flag enables we print the keys found on each prototype and the number of prototypes. BUG= Committed: https://crrev.com/62e9caf7184203ba5b280eb4b6876f22f0531aea Cr-Commit-Position: refs/heads/master@{#34680}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -3 lines) Patch
M src/flag-definitions.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/keys.cc View 5 chunks +22 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Camillo Bruni
PTAL I used this a couple of times for tracing the key distribution on certain ...
4 years, 9 months ago (2016-03-08 18:48:33 UTC) #2
Toon Verwaest
lgtm
4 years, 9 months ago (2016-03-09 19:19:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1779523002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1779523002/1
4 years, 9 months ago (2016-03-10 14:37:12 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-10 15:02:21 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-10 15:03:45 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/62e9caf7184203ba5b280eb4b6876f22f0531aea
Cr-Commit-Position: refs/heads/master@{#34680}

Powered by Google App Engine
This is Rietveld 408576698