Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 1779473002: Strip content-encoding response header from CronetHttpURLConnection response. (Closed)

Created:
4 years, 9 months ago by xunjieli
Modified:
4 years, 9 months ago
Reviewers:
kapishnikov
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Strip content-encoding response header from CronetHttpURLConnection response. Cronet decompresses response body before returning it to consumers, we should strip Content-Encoding headers so that consumers wouldn't try to decompress for a second time. BUG=592700 Committed: https://crrev.com/cee2840c4bcd51313e33f0ab215413f9a8f70480 Cr-Commit-Position: refs/heads/master@{#379903}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address comment #

Messages

Total messages: 12 (6 generated)
xunjieli
Andrei, PTAL.
4 years, 9 months ago (2016-03-08 16:50:42 UTC) #3
kapishnikov
LGTM https://codereview.chromium.org/1779473002/diff/1/components/cronet/android/java/src/org/chromium/net/urlconnection/CronetHttpURLConnection.java File components/cronet/android/java/src/org/chromium/net/urlconnection/CronetHttpURLConnection.java (right): https://codereview.chromium.org/1779473002/diff/1/components/cronet/android/java/src/org/chromium/net/urlconnection/CronetHttpURLConnection.java#newcode565 components/cronet/android/java/src/org/chromium/net/urlconnection/CronetHttpURLConnection.java:565: // TODO(xunjieli): Refactor to reuse code in UrlRequestInfo. ...
4 years, 9 months ago (2016-03-08 19:37:17 UTC) #4
xunjieli
thanks! https://codereview.chromium.org/1779473002/diff/1/components/cronet/android/java/src/org/chromium/net/urlconnection/CronetHttpURLConnection.java File components/cronet/android/java/src/org/chromium/net/urlconnection/CronetHttpURLConnection.java (right): https://codereview.chromium.org/1779473002/diff/1/components/cronet/android/java/src/org/chromium/net/urlconnection/CronetHttpURLConnection.java#newcode565 components/cronet/android/java/src/org/chromium/net/urlconnection/CronetHttpURLConnection.java:565: // TODO(xunjieli): Refactor to reuse code in UrlRequestInfo. ...
4 years, 9 months ago (2016-03-08 19:51:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1779473002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1779473002/20001
4 years, 9 months ago (2016-03-08 19:51:47 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-08 20:44:09 UTC) #10
commit-bot: I haz the power
4 years, 9 months ago (2016-03-08 20:45:21 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/cee2840c4bcd51313e33f0ab215413f9a8f70480
Cr-Commit-Position: refs/heads/master@{#379903}

Powered by Google App Engine
This is Rietveld 408576698