Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issue 1779453002: [ios] Corrected Closure annotation for getEmbedChild_ function. (Closed)

Created:
4 years, 9 months ago by Eugene But (OOO till 7-30)
Modified:
4 years, 9 months ago
Reviewers:
justincohen
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios] Corrected Closure annotation for getEmbedChild_ function. Old annotation was HTMLElement, new one is Node. BUG=593002 Committed: https://crrev.com/1c25fd6e76ccbbcf0f58ff5a45700d2af319569a Cr-Commit-Position: refs/heads/master@{#379854}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M ios/web/web_state/js/resources/plugin_placeholder.js View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Eugene But (OOO till 7-30)
4 years, 9 months ago (2016-03-08 16:40:19 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1779453002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1779453002/1
4 years, 9 months ago (2016-03-08 16:40:38 UTC) #4
justincohen
lgtm
4 years, 9 months ago (2016-03-08 17:15:31 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-08 17:35:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1779453002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1779453002/1
4 years, 9 months ago (2016-03-08 17:42:04 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-08 17:54:45 UTC) #10
commit-bot: I haz the power
4 years, 9 months ago (2016-03-08 17:56:37 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1c25fd6e76ccbbcf0f58ff5a45700d2af319569a
Cr-Commit-Position: refs/heads/master@{#379854}

Powered by Google App Engine
This is Rietveld 408576698