chrome/browser/resources/settings/advanced_page/advanced_page.html - Issue 1779423002: [MD settings] reorder and update settings sections

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/advanced_page/advanced_page.html

Issue 1779423002: [MD settings] reorder and update settings sections (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: line wrap Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/app/settings_google_chrome_strings.grdp ('K') | « chrome/app/settings_strings.grdp ('k') | chrome/browser/resources/settings/basic_page/basic_page.html » ('j') | chrome/browser/resources/settings/basic_page/basic_page.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/advanced_page/advanced_page.html

diff --git a/chrome/browser/resources/settings/advanced_page/advanced_page.html b/chrome/browser/resources/settings/advanced_page/advanced_page.html

index 29044ff34f59fafe8a0eb671f0e87ee729dc93b3..f6a17a46c5fe277b39018b4095b67decaf8ce7a4 100644

--- a/chrome/browser/resources/settings/advanced_page/advanced_page.html

+++ b/chrome/browser/resources/settings/advanced_page/advanced_page.html

@@ -50,7 +50,6 @@

</settings-section>

</template>

</if>

<template is="dom-if" if="[[showPage(pageVisibility.passwordsAndForms)]]"

restamp>

<settings-section

@@ -76,12 +75,9 @@

</settings-downloads-page>

</settings-section>

</template>

- <template is="dom-if" if="[[showPage(pageVisibility.reset)]]" restamp>

- <settings-section page-title="[[i18n('resetPageTitle')]]"

- current-route="[[currentRoute]]" section="reset">

- <settings-reset-page></settings-reset-page>

- </settings-section>

- </template>

+

dpapad 2016/03/11 02:07:23 Nit: "TODO(<author>): Add Google Cloud ..." Other

dschuyler 2016/03/11 02:28:09 Done.

<!-- TODO(dbeam): find somewhere to stuff "Add more accessibility features"

on desktop. -->

@@ -100,6 +96,12 @@

</settings-section>

</template>

</if>

+ <template is="dom-if" if="[[showPage(pageVisibility.reset)]]" restamp>

+ <settings-section page-title="[[i18n('resetPageTitle')]]"

+ current-route="[[currentRoute]]" section="reset">

+ <settings-reset-page></settings-reset-page>

+ </settings-section>

+ </template>

</template>

</dom-module>