[MD settings] reorder and update settings sections

[MD settings] reorder and update settings sections

This CL reorders the sections in the MD settings to
more closely match the order listed in the Combined
Chrome Settings Hierarchy doc.  The entries in the
side nav have also been reordered and some menu items
were added to flesh out the full menu (even though
the sections are not complete).  There are some TODOs
for icons that will happen in a later CL.

BUG=593989
Committed: https://crrev.com/2d4b02bdc8617296acb108c67ccaa246ef2f37ee
Cr-Commit-Position: refs/heads/master@{#380749}

[dschuyler, 2016-03-11 01:16:34]

dschuyler@chromium.org changed reviewers:
+ dpapad@chromium.org

[dschuyler, 2016-03-11 01:16:35]

Screen shots at http://imgur.com/a/8AU53

[dpapad, 2016-03-11 02:07:24]

LGTM with nits.

https://codereview.chromium.org/1779423002/diff/40001/chrome/app/settings_goo...
File chrome/app/settings_google_chrome_strings.grdp (right):

https://codereview.chromium.org/1779423002/diff/40001/chrome/app/settings_goo...
chrome/app/settings_google_chrome_strings.grdp:12: About Chrome
Should this be "About Google Chrome" similar to
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/app/google_...

https://codereview.chromium.org/1779423002/diff/40001/chrome/browser/resource...
File chrome/browser/resources/settings/advanced_page/advanced_page.html (right):

https://codereview.chromium.org/1779423002/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/advanced_page/advanced_page.html:79: <!-- Add
Google Cloud Print section here (between Downloads and a11y). -->
Nit: "TODO(<author>): Add Google Cloud ..."

Otherwise this comment will not be returned when one greps for "TODO"

https://codereview.chromium.org/1779423002/diff/40001/chrome/browser/resource...
File chrome/browser/resources/settings/basic_page/basic_page.html (right):

https://codereview.chromium.org/1779423002/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/basic_page/basic_page.html:36: <template
is="dom-if" if="[[showPage(pageVisibility.people)]]" restamp>
Indentation off by 1 here?

[dschuyler, 2016-03-11 02:28:09]

https://codereview.chromium.org/1779423002/diff/40001/chrome/app/settings_goo...
File chrome/app/settings_google_chrome_strings.grdp (right):

https://codereview.chromium.org/1779423002/diff/40001/chrome/app/settings_goo...
chrome/app/settings_google_chrome_strings.grdp:12: About Chrome
On 2016/03/11 02:07:23, dpapad wrote:
> Should this be "About Google Chrome" similar to
>
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/app/google_...

Excellent question.  In the doc I got from tbuckley@ it is
"About Chrome".  I will double check with him and change 
it in a future CL if needed.

https://codereview.chromium.org/1779423002/diff/40001/chrome/browser/resource...
File chrome/browser/resources/settings/advanced_page/advanced_page.html (right):

https://codereview.chromium.org/1779423002/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/advanced_page/advanced_page.html:79: <!-- Add
Google Cloud Print section here (between Downloads and a11y). -->
On 2016/03/11 02:07:23, dpapad wrote:
> Nit: "TODO(<author>): Add Google Cloud ..."
> 
> Otherwise this comment will not be returned when one greps for "TODO"

Done.

https://codereview.chromium.org/1779423002/diff/40001/chrome/browser/resource...
File chrome/browser/resources/settings/basic_page/basic_page.html (right):

https://codereview.chromium.org/1779423002/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/basic_page/basic_page.html:36: <template
is="dom-if" if="[[showPage(pageVisibility.people)]]" restamp>
On 2016/03/11 02:07:23, dpapad wrote:
> Indentation off by 1 here?

Done.

[dschuyler, 2016-03-11 22:02:57]

The CQ bit was checked by dschuyler@chromium.org

[dschuyler, 2016-03-11 22:02:57]

The patchset sent to the CQ was uploaded after l-g-t-m from dpapad@chromium.org
Link to the patchset: https://codereview.chromium.org/1779423002/#ps60001
(title: "review changes")

[commit-bot: I haz the power, 2016-03-11 22:03:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1779423002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1779423002/60001

[commit-bot: I haz the power, 2016-03-11 22:10:49]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-03-11 22:12:29]

Description was changed from

==========
[MD settings] reorder and update settings sections

This CL reorders the sections in the MD settings to
more closely match the order listed in the Combined
Chrome Settings Hierarchy doc.  The entries in the
side nav have also been reordered and some menu items
were added to flesh out the full menu (even though
the sections are not complete).  There are some TODOs
for icons that will happen in a later CL.

BUG=593989
==========

to

==========
[MD settings] reorder and update settings sections

This CL reorders the sections in the MD settings to
more closely match the order listed in the Combined
Chrome Settings Hierarchy doc.  The entries in the
side nav have also been reordered and some menu items
were added to flesh out the full menu (even though
the sections are not complete).  There are some TODOs
for icons that will happen in a later CL.

BUG=593989

Committed: https://crrev.com/2d4b02bdc8617296acb108c67ccaa246ef2f37ee
Cr-Commit-Position: refs/heads/master@{#380749}
==========

[commit-bot: I haz the power, 2016-03-11 22:12:30]

Patchset 4 (id:??) landed as
https://crrev.com/2d4b02bdc8617296acb108c67ccaa246ef2f37ee
Cr-Commit-Position: refs/heads/master@{#380749}