chrome/browser/ui/cocoa/certificate_viewer_mac_browsertest.mm - Issue 1779383002: MacViews: Remove constrained window dependencies for certificate viewer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/certificate_viewer_mac_browsertest.mm

Issue 1779383002: MacViews: Remove constrained window dependencies for certificate viewer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rsesek@ review - merge displayForWebContents & initWithCertificate, etc. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/certificate_viewer_mac.h ('K') | « chrome/browser/ui/cocoa/certificate_viewer_mac.mm ('k') | chrome/browser/ui/cocoa/certificate_viewer_mac_cocoa.h » ('j') | chrome/browser/ui/cocoa/certificate_viewer_mac_cocoa.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/certificate_viewer_mac_browsertest.mm

diff --git a/chrome/browser/ui/cocoa/certificate_viewer_mac_browsertest.mm b/chrome/browser/ui/cocoa/certificate_viewer_mac_browsertest.mm

index 1fbd43cb1d955a52fee9b2eb85618d87c5d788ea..647c8bb0f94016a4315c5d0b10135fd6327d26e8 100644

--- a/chrome/browser/ui/cocoa/certificate_viewer_mac_browsertest.mm

+++ b/chrome/browser/ui/cocoa/certificate_viewer_mac_browsertest.mm

@@ -6,7 +6,7 @@

#include "chrome/browser/ui/browser.h"

#include "chrome/browser/ui/browser_commands.h"

-#include "chrome/browser/ui/cocoa/certificate_viewer_mac.h"

+#include "chrome/browser/ui/certificate_viewer_mac.h"

#include "chrome/browser/ui/tabs/tab_strip_model.h"

#include "chrome/test/base/in_process_browser_test.h"

#include "components/web_modal/web_contents_modal_dialog_manager.h"

@@ -20,7 +20,7 @@

using web_modal::WebContentsModalDialogManager;

-typedef InProcessBrowserTest SSLCertificateViewerMacTest;

+using SSLCertificateViewerMacTest = InProcessBrowserTest;

namespace {