components/constrained_window/constrained_window_views.cc - Issue 1779383002: MacViews: Remove constrained window dependencies for certificate viewer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/constrained_window/constrained_window_views.cc

Issue 1779383002: MacViews: Remove constrained window dependencies for certificate viewer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Keep a reference to the sheet window in single_web_contents_dialog_manager_cocoa.mm. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/cocoa/certificate_viewer_mac_views.mm ('K') | « components/constrained_window/constrained_window_views.h ('k') | components/web_modal/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/constrained_window/constrained_window_views.cc

diff --git a/components/constrained_window/constrained_window_views.cc b/components/constrained_window/constrained_window_views.cc

index def5232fc9782603559d380c6499264f1c8ac6b5..4616e4f1eec6eabd8ef3827cc6c3ea39e1790c5c 100644

--- a/components/constrained_window/constrained_window_views.cc

+++ b/components/constrained_window/constrained_window_views.cc

@@ -141,8 +141,9 @@ views::Widget* ShowWebModalDialogViews(

content::WebContents* web_contents =

guest_view::GuestViewBase::GetTopLevelWebContents(initiator_web_contents);

views::Widget* widget = CreateWebModalDialogViews(dialog, web_contents);

- web_modal::WebContentsModalDialogManager::FromWebContents(web_contents)

- ->ShowModalDialog(widget->GetNativeWindow());

+ web_modal::WebContentsModalDialogManager* manager =

+ web_modal::WebContentsModalDialogManager::FromWebContents(web_contents);

+ manager->ShowModalDialog(widget->GetNativeWindow());

return widget;

}

@@ -192,4 +193,4 @@ views::Widget* CreateBrowserModalDialogViews(views::DialogDelegate* dialog,

return widget;

}

-} // namespace constrained window

+} // namespace constrained_window