chrome/browser/ui/views/native_web_contents_modal_dialog_manager_views.h - Issue 1779383002: MacViews: Remove constrained window dependencies for certificate viewer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/native_web_contents_modal_dialog_manager_views.h

Issue 1779383002: MacViews: Remove constrained window dependencies for certificate viewer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Move out ConstrainedWindowSheet to Cocoa-only, other review comments. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/cocoa/native_web_contents_modal_dialog_manager_views_mac.mm ('K') | « chrome/browser/ui/cocoa/native_web_contents_modal_dialog_manager_views_mac.mm ('k') | chrome/browser/ui/views/native_web_contents_modal_dialog_manager_views.cc » ('j') | components/constrained_window/constrained_window_views.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/native_web_contents_modal_dialog_manager_views.h

diff --git a/chrome/browser/ui/views/native_web_contents_modal_dialog_manager_views.h b/chrome/browser/ui/views/native_web_contents_modal_dialog_manager_views.h

index 21b2b9b3bf31f661d43accca3ac819642146bcde..f1081c67f72d95714e07b90dfcf08d2bd3adf245 100644

--- a/chrome/browser/ui/views/native_web_contents_modal_dialog_manager_views.h

+++ b/chrome/browser/ui/views/native_web_contents_modal_dialog_manager_views.h

@@ -59,8 +59,18 @@ class NativeWebContentsModalDialogManagerViews

void HostChanged(web_modal::WebContentsModalDialogHost* new_host) override;

gfx::NativeWindow dialog() override;

- private:

+ protected:

+ web_modal::SingleWebContentsDialogManagerDelegate* native_delegate();

tapted 2016/05/31 07:44:48 nit: this can be defined inline -- just `return na

Patti Lor 2016/06/06 06:52:46 Done.

+ // By default just calls widget->Show() or Hide(), but allows a derived class

+ // to override in order to hide an alternate way (e.g. if the default hide

+ // would tear down attached dialogs too early).

+ virtual void ShowWidget(views::Widget* widget);

+ virtual void HideWidget(views::Widget* widget);

static views::Widget* GetWidget(gfx::NativeWindow dialog);

+ private:

void WidgetClosing(views::Widget* widget);

web_modal::SingleWebContentsDialogManagerDelegate* native_delegate_;