Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(873)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/chrome_browser_ui.gypi

Issue 1779383002: MacViews: Remove constrained window dependencies for certificate viewer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Position correctly (kind of) & block on tab only. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/ui/views/mac/certificate_viewer_views_mac.mm ('K') | « chrome/browser/ui/views/mac/web_contents_modal_dialog_manager_views_mac.mm ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/chrome_browser_ui.gypi
diff --git a/chrome/chrome_browser_ui.gypi b/chrome/chrome_browser_ui.gypi
index 9d913a4933198899945c11fb850e951871b90f78..443c18f12d0fe5ce205d2a9d292008c81c00ff3c 100644
--- a/chrome/chrome_browser_ui.gypi
+++ b/chrome/chrome_browser_ui.gypi
@@ -910,6 +910,8 @@
'browser/ui/cocoa/bubble_sync_promo_controller.mm',
'browser/ui/cocoa/bubble_view.h',
'browser/ui/cocoa/bubble_view.mm',
+ 'browser/ui/cocoa/certificate_viewer_mac.h',
+ 'browser/ui/cocoa/certificate_viewer_mac.mm',
'browser/ui/cocoa/chrome_browser_window.h',
'browser/ui/cocoa/chrome_browser_window.mm',
'browser/ui/cocoa/chrome_event_processing_window.h',
@@ -931,6 +933,12 @@
'browser/ui/cocoa/constrained_window/constrained_window_custom_sheet.mm',
'browser/ui/cocoa/constrained_window/constrained_window_custom_window.h',
'browser/ui/cocoa/constrained_window/constrained_window_custom_window.mm',
+ 'browser/ui/cocoa/constrained_window/constrained_window_mac.h',
+ 'browser/ui/cocoa/constrained_window/constrained_window_mac.mm',
+ 'browser/ui/cocoa/constrained_window/constrained_window_sheet_controller.h',
+ 'browser/ui/cocoa/constrained_window/constrained_window_sheet_controller.mm',
+ 'browser/ui/cocoa/constrained_window/constrained_window_sheet_info.h',
+ 'browser/ui/cocoa/constrained_window/constrained_window_sheet_info.mm',
'browser/ui/cocoa/constrained_window/constrained_window_web_dialog_sheet.h',
'browser/ui/cocoa/constrained_window/constrained_window_web_dialog_sheet.mm',
'browser/ui/cocoa/content_settings/collected_cookies_mac.h',
@@ -1226,6 +1234,7 @@
'browser/ui/cocoa/screen_capture_notification_ui_cocoa.mm',
'browser/ui/cocoa/session_crashed_bubble.mm',
'browser/ui/cocoa/simple_message_box_mac.mm',
+ 'browser/ui/cocoa/single_web_contents_dialog_manager_cocoa.mm',
'browser/ui/cocoa/spinner_view.h',
'browser/ui/cocoa/spinner_view.mm',
'browser/ui/cocoa/sprite_view.h',
@@ -1410,6 +1419,8 @@
'browser/ui/webui/certificate_viewer_webui.h',
],
'chrome_browser_ui_mac_sources': [
+ 'browser/mac/certificate_viewer_base.h',
+ 'browser/mac/certificate_viewer_base.mm',
'browser/ui/chrome_style.cc',
'browser/ui/chrome_style.h',
'browser/ui/cocoa/accelerator_utils_cocoa.mm',
@@ -1427,20 +1438,13 @@
'browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller.mm',
'browser/ui/cocoa/browser_window_command_handler.h',
'browser/ui/cocoa/browser_window_command_handler.mm',
- 'browser/ui/cocoa/certificate_viewer_mac.mm',
'browser/ui/cocoa/chrome_command_dispatcher_delegate.h',
'browser/ui/cocoa/chrome_command_dispatcher_delegate.mm',
'browser/ui/cocoa/color_chooser_mac.mm',
'browser/ui/cocoa/confirm_quit.h',
'browser/ui/cocoa/confirm_quit_panel_controller.h',
'browser/ui/cocoa/confirm_quit_panel_controller.mm',
- 'browser/ui/cocoa/constrained_window/constrained_window_mac.h',
- 'browser/ui/cocoa/constrained_window/constrained_window_mac.mm',
'browser/ui/cocoa/constrained_window/constrained_window_sheet.h',
- 'browser/ui/cocoa/constrained_window/constrained_window_sheet_controller.h',
- 'browser/ui/cocoa/constrained_window/constrained_window_sheet_controller.mm',
- 'browser/ui/cocoa/constrained_window/constrained_window_sheet_info.h',
- 'browser/ui/cocoa/constrained_window/constrained_window_sheet_info.mm',
'browser/ui/cocoa/dock_icon.h',
'browser/ui/cocoa/dock_icon.mm',
'browser/ui/cocoa/download/download_item_drag_mac.mm',
@@ -1489,7 +1493,6 @@
'browser/ui/cocoa/renderer_context_menu/render_view_context_menu_mac.h',
'browser/ui/cocoa/renderer_context_menu/render_view_context_menu_mac.mm',
'browser/ui/cocoa/single_web_contents_dialog_manager_cocoa.h',
tapted 2016/03/21 02:47:13 header should move as well
Patti Lor 2016/05/03 00:05:01 Done.
- 'browser/ui/cocoa/single_web_contents_dialog_manager_cocoa.mm',
'browser/ui/cocoa/status_icons/status_icon_mac.h',
'browser/ui/cocoa/status_icons/status_icon_mac.mm',
'browser/ui/cocoa/status_icons/status_tray_mac.h',
@@ -2562,6 +2565,10 @@
'chrome_browser_ui_views_mac_experimental_sources': [
'browser/ui/views/apps/chrome_app_window_client_views_mac.mm',
'browser/ui/views/infobars/legacy_infobars_mac.cc',
+ 'browser/ui/views/mac/certificate_viewer_views_mac.h',
+ 'browser/ui/views/mac/certificate_viewer_views_mac.mm',
+ 'browser/ui/views/mac/web_contents_modal_dialog_manager_views_mac.h',
tapted 2016/03/21 02:47:13 I'm pretty sure we use this to parent toolkit-view
Patti Lor 2016/05/03 00:05:01 Done.
+ 'browser/ui/views/mac/web_contents_modal_dialog_manager_views_mac.mm',
],
# Windows-only. Assume ash/aura/views.
'chrome_browser_ui_win_sources': [
« chrome/browser/ui/views/mac/certificate_viewer_views_mac.mm ('K') | « chrome/browser/ui/views/mac/web_contents_modal_dialog_manager_views_mac.mm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698