Chromium Code Reviews| Index: components/web_modal/web_contents_modal_dialog_views.cc |
| diff --git a/extensions/shell/browser/shell_web_contents_modal_dialog_manager.cc b/components/web_modal/web_contents_modal_dialog_views.cc |
| similarity index 62% |
| copy from extensions/shell/browser/shell_web_contents_modal_dialog_manager.cc |
| copy to components/web_modal/web_contents_modal_dialog_views.cc |
| index 266f37960dfc8ffa4f482861fd42b3cb24f21708..48ae132910390ff5356b4d40571c7cbb8d9128e3 100644 |
| --- a/extensions/shell/browser/shell_web_contents_modal_dialog_manager.cc |
| +++ b/components/web_modal/web_contents_modal_dialog_views.cc |
| @@ -1,4 +1,4 @@ |
| -// Copyright 2014 The Chromium Authors. All rights reserved. |
| +// Copyright 2016 The Chromium Authors. All rights reserved. |
| // Use of this source code is governed by a BSD-style license that can be |
| // found in the LICENSE file. |
| @@ -7,12 +7,11 @@ |
| namespace web_modal { |
| SingleWebContentsDialogManager* |
| -WebContentsModalDialogManager::CreateNativeWebModalManager( |
| +WebContentsModalDialogManager::CreateParentedNativeWebModalManager( |
| gfx::NativeWindow dialog, |
| SingleWebContentsDialogManagerDelegate* native_delegate) { |
| - // TODO(oshima): Investigate if we need to implement this. |
| - NOTREACHED(); |
| - return NULL; |
| + NOTIMPLEMENTED(); |
|
tapted
2016/05/13 06:08:47
can this be NOTREACHED()?
And even though I've sa
Patti Lor
2016/05/18 04:48:38
Done.
|
| + return nullptr; |
| } |
| } // namespace web_modal |