Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(693)

Unified Diff: components/web_modal/web_contents_modal_dialog_manager.h

Issue 1779383002: MacViews: Remove constrained window dependencies for certificate viewer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase & address review comments. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/web_modal/web_contents_modal_dialog_manager.h
diff --git a/components/web_modal/web_contents_modal_dialog_manager.h b/components/web_modal/web_contents_modal_dialog_manager.h
index 6505301c215f73fa3e250b800f239dd3de988208..85054d37eeae9b57999a4abb50552c220b112892 100644
--- a/components/web_modal/web_contents_modal_dialog_manager.h
+++ b/components/web_modal/web_contents_modal_dialog_manager.h
@@ -33,9 +33,13 @@ class WebContentsModalDialogManager
gfx::NativeWindow dialog,
SingleWebContentsDialogManagerDelegate* native_delegate);
+ static SingleWebContentsDialogManager* CreateParentedNativeWebModalManager(
tapted 2016/05/13 06:08:47 #if defined(OS_MACOSX) for this There should be a
Patti Lor 2016/05/18 04:48:38 Done.
+ gfx::NativeWindow dialog,
+ SingleWebContentsDialogManagerDelegate* native_delegate);
+
// Shows the dialog as a web contents modal dialog. The dialog will notify via
// WillClose() when it is being destroyed.
- void ShowModalDialog(gfx::NativeWindow dialog);
+ void ShowModalDialog(gfx::NativeWindow dialog, bool parented = false);
tapted 2016/05/13 06:08:46 I think we should overload this instead, so we can
Patti Lor 2016/05/18 04:48:38 Done.
// Allow clients to supply their own native dialog manager. Suitable for
// bubble clients.

Powered by Google App Engine
This is Rietveld 408576698