Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8136)

Unified Diff: chrome/browser/ui/views/native_web_modal_manager.cc

Issue 1779383002: MacViews: Remove constrained window dependencies for certificate viewer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix positioning after resize from top, don't allow interaction with tab WebContents while certifica… Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/native_web_modal_manager.cc
diff --git a/extensions/shell/browser/shell_web_contents_modal_dialog_manager.cc b/chrome/browser/ui/views/native_web_modal_manager.cc
similarity index 60%
copy from extensions/shell/browser/shell_web_contents_modal_dialog_manager.cc
copy to chrome/browser/ui/views/native_web_modal_manager.cc
index 266f37960dfc8ffa4f482861fd42b3cb24f21708..c6eef977fdb3ada96d869bc788bc9b70c52e2bdf 100644
--- a/extensions/shell/browser/shell_web_contents_modal_dialog_manager.cc
+++ b/chrome/browser/ui/views/native_web_modal_manager.cc
@@ -1,8 +1,8 @@
-// Copyright 2014 The Chromium Authors. All rights reserved.
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
tapted 2016/05/04 03:29:25 `(c) 2012` -> `2016`
Patti Lor 2016/05/11 01:35:19 This file is now gone because of a slight refactor
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "components/web_modal/web_contents_modal_dialog_manager.h"
+#include "chrome/browser/ui/views/web_contents_modal_dialog_manager_views.h"
namespace web_modal {
@@ -10,9 +10,7 @@ SingleWebContentsDialogManager*
WebContentsModalDialogManager::CreateNativeWebModalManager(
gfx::NativeWindow dialog,
SingleWebContentsDialogManagerDelegate* native_delegate) {
- // TODO(oshima): Investigate if we need to implement this.
- NOTREACHED();
- return NULL;
+ return new NativeWebContentsModalDialogManagerViews(dialog, native_delegate);
}
} // namespace web_modal

Powered by Google App Engine
This is Rietveld 408576698