Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3038)

Unified Diff: chrome/browser/ui/cocoa/certificate_viewer_mac_views.h

Issue 1779383002: MacViews: Remove constrained window dependencies for certificate viewer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix positioning after resize from top, don't allow interaction with tab WebContents while certifica… Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/certificate_viewer_mac_views.h
diff --git a/chrome/browser/ui/cocoa/certificate_viewer_mac_views.h b/chrome/browser/ui/cocoa/certificate_viewer_mac_views.h
new file mode 100644
index 0000000000000000000000000000000000000000..0360d81565f28b9661cf40b668eb5eac3b0e1f41
--- /dev/null
+++ b/chrome/browser/ui/cocoa/certificate_viewer_mac_views.h
@@ -0,0 +1,36 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_UI_VIEWS_MAC_CERTIFICATE_VIEWER_VIEWS_MAC_H_
tapted 2016/05/04 03:29:24 this need to match the path
Patti Lor 2016/05/11 01:35:18 Done.
+#define CHROME_BROWSER_UI_VIEWS_MAC_CERTIFICATE_VIEWER_VIEWS_MAC_H_
+
+#include <memory>
+
+#import "chrome/browser/ui/cocoa/certificate_viewer_mac.h"
+
+namespace views {
+class Widget;
+class WidgetDelegateView;
+}
+
+/** Certificate viewer class for MacViews which handles displaying and closing
tapted 2016/05/04 03:29:24 nit: update comment style. more below
Patti Lor 2016/05/11 01:35:18 Done.
+ * the Cocoa certificate viewer.
+ */
+@interface SSLCertificateViewerViewsMac : SSLCertificateViewerMac {
+ @private
+ std::unique_ptr<views::Widget> dialog_;
tapted 2016/05/04 03:29:24 perhaps call this overlayWindow_?
Patti Lor 2016/05/11 01:35:18 Done, have also moved the overlayWindow_ variable
+ views::WidgetDelegateView* delegate_;
tapted 2016/05/04 03:29:24 is this member needed? - looks like it could be a
Patti Lor 2016/05/11 01:35:18 Done, removed!
+}
+
+/** Closes the certificate viewer properly. */
+- (void)sheetDidEnd:(NSWindow*)parent
+ returnCode:(NSInteger)returnCode
+ context:(void*)context;
+
+// SSLCertificateViewerMac implementation override.
+- (void)displayForWebContents:(content::WebContents*)webContents;
tapted 2016/05/04 03:29:24 ObjC overrides don't need to be redeclared
Patti Lor 2016/05/11 01:35:18 Done.
+
+@end
+
+#endif // CHROME_BROWSER_UI_VIEWS_MAC_CERTIFICATE_VIEWER_VIEWS_MAC_H_

Powered by Google App Engine
This is Rietveld 408576698