MacViews: Remove constrained window dependencies for certificate viewer.

chrome/browser/mac/certificate_viewer_base.mm

-// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Copyright (c) 2016 The Chromium Authors. All rights reserved.

[tapted, 2016/03/21 02:47:12]

nit: no (c)

[Patti Lor, 2016/05/03 00:05:00]

Done.

 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#import "chrome/browser/ui/cocoa/certificate_viewer_mac.h"
-
-#include <Security/Security.h>
-#include <SecurityInterface/SFCertificatePanel.h>
-#include <vector>
+#include "chrome/browser/mac/certificate_viewer_base.h"

[tapted, 2016/03/21 02:47:12]

import

[Patti Lor, 2016/05/03 00:05:00]

Done.

 
 #include "base/mac/foundation_util.h"
 #include "base/mac/scoped_cftyperef.h"
-#include "base/macros.h"
-#include "chrome/browser/certificate_viewer.h"
-#import "chrome/browser/ui/cocoa/constrained_window/constrained_window_mac.h"
-#import "chrome/browser/ui/cocoa/constrained_window/constrained_window_sheet.h"
-#import "chrome/browser/ui/cocoa/constrained_window/constrained_window_sheet_controller.h"
 #include "net/cert/x509_certificate.h"
 #include "net/cert/x509_util_mac.h"
-#import "ui/base/cocoa/window_size_constants.h"
 
-class SSLCertificateViewerCocoaBridge;
 
-@interface SFCertificatePanel (SystemPrivate)
-// A system-private interface that dismisses a panel whose sheet was started by
-// -beginSheetForWindow:
-//        modalDelegate:
-//       didEndSelector:
-//          contextInfo:
-//         certificates:
-//            showGroup:
-// as though the user clicked the button identified by returnCode. Verified
-// present in 10.8.
-- (void)_dismissWithCode:(NSInteger)code;
-@end
-
-@interface SSLCertificateViewerCocoa ()
-- (void)onConstrainedWindowClosed;
-@end
-
-class SSLCertificateViewerCocoaBridge : public ConstrainedWindowMacDelegate {
- public:
-  explicit SSLCertificateViewerCocoaBridge(SSLCertificateViewerCocoa *
-                                           controller)
-      : controller_(controller) {
-  }
-
-  virtual ~SSLCertificateViewerCocoaBridge() {}
-
-  // ConstrainedWindowMacDelegate implementation:
-  void OnConstrainedWindowClosed(ConstrainedWindowMac* window) override {
-    // |onConstrainedWindowClosed| will delete the sheet which might be still
-    // in use higher up the call stack. Wait for the next cycle of the event
-    // loop to call this function.
-    [controller_ performSelector:@selector(onConstrainedWindowClosed)
-                      withObject:nil
-                      afterDelay:0];
-  }
-
- private:
-  SSLCertificateViewerCocoa* controller_;  // weak
-
-  DISALLOW_COPY_AND_ASSIGN(SSLCertificateViewerCocoaBridge);
-};
-
-void ShowCertificateViewer(content::WebContents* web_contents,
-                           gfx::NativeWindow parent,
-                           net::X509Certificate* cert) {
-  // SSLCertificateViewerCocoa will manage its own lifetime and will release
-  // itself when the dialog is closed.
-  // See -[SSLCertificateViewerCocoa onConstrainedWindowClosed].
-  SSLCertificateViewerCocoa* viewer =
-      [[SSLCertificateViewerCocoa alloc] initWithCertificate:cert];
-  [viewer displayForWebContents:web_contents];
-}
-
-@implementation SSLCertificateViewerCocoa
+@implementation SSLCertificateViewerMacBase
 
 - (id)initWithCertificate:(net::X509Certificate*)certificate {
   if ((self = [super init])) {
     base::ScopedCFTypeRef<CFArrayRef> cert_chain(
         certificate->CreateOSCertChainForCert());
     NSArray* certificates = base::mac::CFToNSCast(cert_chain.get());
     certificates_.reset([certificates retain]);
   }
   return self;
 }
 
-- (void)sheetDidEnd:(NSWindow*)parent
-         returnCode:(NSInteger)returnCode
-            context:(void*)context {
-  if (!closePending_)
-    constrainedWindow_->CloseWebContentsModalDialog();
-}
-
 - (void)displayForWebContents:(content::WebContents*)webContents {
   // Explicitly disable revocation checking, regardless of user preferences
   // or system settings. The behaviour of SFCertificatePanel is to call
   // SecTrustEvaluate on the certificate(s) supplied, effectively
   // duplicating the behaviour of net::X509Certificate::Verify(). However,
   // this call stalls the UI if revocation checking is enabled in the
   // Keychain preferences or if the cert may be an EV cert. By disabling
   // revocation checking, the stall is limited to the time taken for path
   // building and verification, which should be minimized due to the path
   // being provided in |certificates|. This does not affect normal
@@ skipping 20 matching lines @@
   CFRelease(basic_policy);
 
   status = net::x509_util::CreateRevocationPolicies(false, false, policies);
   if (status != noErr) {
     NOTREACHED();
     return;
   }
 
   panel_.reset([[SFCertificatePanel alloc] init]);
   [panel_ setPolicies:(id) policies.get()];
-
-  constrainedWindow_ =
-      CreateAndShowWebModalDialogMac(observer_.get(), webContents, self);
 }
 
 - (NSWindow*)overlayWindow {
   return overlayWindow_;
 }
 
+// ConstrainedWindowSheet:

[tapted, 2016/03/21 02:47:12]

For objc the current approach is something like

// ConstrainedWindowSheet protocol implementation.

[Patti Lor, 2016/05/03 00:05:00]

Done.

+
 - (void)showSheetForWindow:(NSWindow*)window {
   overlayWindow_.reset([window retain]);
   [panel_ beginSheetForWindow:window
                 modalDelegate:self
                didEndSelector:@selector(sheetDidEnd:
                                          returnCode:
                                             context:)
-                  contextInfo:NULL
-                 certificates:certificates_
-                    showGroup:YES];
+                 contextInfo:NULL

[tapted, 2016/03/21 02:47:12]

rollback indenting change

[Patti Lor, 2016/05/03 00:05:00]

Done.

+                certificates:certificates_
+                   showGroup:YES];
 }
 
 - (void)closeSheetWithAnimation:(BOOL)withAnimation {
   closePending_ = YES;
   overlayWindow_.reset();
-  // Closing the sheet using -[NSApp endSheet:] doesn't work so use the private
-  // method.
+  // Closing the sheet using -[NSApp endSheet:] doesn't work so use the

[tapted, 2016/03/21 02:47:12]

re-wrap

[Patti Lor, 2016/05/03 00:05:00]

Done.

+  // private method.
   [panel_ _dismissWithCode:NSFileHandlingPanelCancelButton];
 }
 
 - (void)hideSheet {
   NSWindow* sheetWindow = [overlayWindow_ attachedSheet];
   [sheetWindow setAlphaValue:0.0];
 
   oldResizesSubviews_ = [[sheetWindow contentView] autoresizesSubviews];
   [[sheetWindow contentView] setAutoresizesSubviews:NO];
 }
@@ skipping 18 matching lines @@
 }
 
 - (void)resizeWithNewSize:(NSSize)preferredSize {
   // NOOP
 }
 
 - (NSWindow*)sheetWindow {
   return panel_;
 }
 
-- (void)onConstrainedWindowClosed {
-  panel_.reset();
-  constrainedWindow_.reset();
-  [self release];
-}
-
 @end