Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1779353002: Deprecate mojo/public/c/system/core.h. (Closed)

Created:
4 years, 9 months ago by viettrungluu
Modified:
4 years, 9 months ago
Reviewers:
jamesr
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, darin (slow to review), gregsimon, mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+mojopublicwatch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Deprecate mojo/public/c/system/core.h. Convert the places where we include it. I'll leave core.h in temporarily, to make rolling/updating consumers easier, but it should eventually be removed. R=jamesr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/4182638e4cf54ca49879f2f37f3086d393ca433e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -41 lines) Patch
M mojo/android/system/core_impl.cc View 1 chunk +5 lines, -1 line 0 comments Download
M mojo/dart/embedder/dart_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/nacl/sfi/nacl_bindings/mojo_irt.c View 1 chunk +4 lines, -1 line 0 comments Download
M mojo/nacl/sfi/nacl_bindings/mojo_syscall.cc View 1 chunk +4 lines, -1 line 0 comments Download
M mojo/nacl/sfi/nacl_bindings_generator/libmojo.cc.tmpl View 1 chunk +5 lines, -1 line 0 comments Download
M mojo/nacl/sfi/nacl_bindings_generator/mojo_irt.c.tmpl View 1 chunk +4 lines, -1 line 0 comments Download
M mojo/nacl/sfi/nacl_bindings_generator/mojo_syscall.cc.tmpl View 1 chunk +4 lines, -1 line 0 comments Download
M mojo/public/c/system/core.h View 1 chunk +4 lines, -0 lines 0 comments Download
M mojo/public/c/system/tests/core_perftest.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M mojo/public/c/system/tests/core_unittest.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M mojo/public/c/system/tests/core_unittest_pure_c.c View 2 chunks +4 lines, -2 lines 0 comments Download
M mojo/public/cpp/system/handle.h View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/public/go/system/core.go View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/java/system/src/org/chromium/mojo/system/Core.java View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/public/js/core.js View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/public/platform/dart/dart_handle_watcher.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/platform/dart/mojo_natives.cc View 1 chunk +5 lines, -1 line 0 comments Download
M mojo/public/platform/nacl/libmojo.cc View 1 chunk +5 lines, -1 line 0 comments Download
M mojo/public/platform/native/system_impl_private.h View 1 chunk +3 lines, -0 lines 0 comments Download
M mojo/public/platform/native/system_impl_private_thunks.h View 3 chunks +6 lines, -4 lines 0 comments Download
M mojo/public/platform/native/system_impl_private_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/public/platform/native/system_thunks.h View 1 chunk +5 lines, -1 line 0 comments Download
M mojo/public/platform/native_cgo/system_cgo.go View 1 chunk +6 lines, -1 line 0 comments Download
M mojo/public/python/c_async_waiter.pxd View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/python/c_core.pxd View 5 chunks +5 lines, -6 lines 0 comments Download
M services/js/system/mojo_runner_delegate.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
viettrungluu
4 years, 9 months ago (2016-03-10 21:56:09 UTC) #1
jamesr
I feel like we'll churn people a lot but if you're willing to do that ...
4 years, 9 months ago (2016-03-10 21:58:41 UTC) #2
viettrungluu
4 years, 9 months ago (2016-03-10 22:12:44 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
4182638e4cf54ca49879f2f37f3086d393ca433e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698