Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Unified Diff: runtime/vm/service.cc

Issue 1779333004: Add profile data to getSourceReport (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/profiler_test.cc ('k') | runtime/vm/source_report.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/service.cc
diff --git a/runtime/vm/service.cc b/runtime/vm/service.cc
index aca3a5b713494324f3422d90d58114bc74e91dee..fb7a5dba626422ebcdbe6b45e9a19fb44e38443f 100644
--- a/runtime/vm/service.cc
+++ b/runtime/vm/service.cc
@@ -2400,15 +2400,11 @@ static bool GetCoverage(Thread* thread, JSONStream* js) {
}
-static const char* kCallSitesStr = "_CallSites";
-static const char* kCoverageStr = "Coverage";
-static const char* kPossibleBreakpointsStr = "PossibleBreakpoints";
-
-
static const char* const report_enum_names[] = {
- kCallSitesStr,
- kCoverageStr,
- kPossibleBreakpointsStr,
+ SourceReport::kCallSitesStr,
+ SourceReport::kCoverageStr,
+ SourceReport::kPossibleBreakpointsStr,
+ SourceReport::kProfileStr,
NULL,
};
@@ -2436,12 +2432,14 @@ static bool GetSourceReport(Thread* thread, JSONStream* js) {
const char** reports = reports_parameter->Parse(thread->zone(), reports_str);
intptr_t report_set = 0;
while (*reports != NULL) {
- if (strcmp(*reports, kCallSitesStr) == 0) {
+ if (strcmp(*reports, SourceReport::kCallSitesStr) == 0) {
report_set |= SourceReport::kCallSites;
- } else if (strcmp(*reports, kCoverageStr) == 0) {
+ } else if (strcmp(*reports, SourceReport::kCoverageStr) == 0) {
report_set |= SourceReport::kCoverage;
- } else if (strcmp(*reports, kPossibleBreakpointsStr) == 0) {
+ } else if (strcmp(*reports, SourceReport::kPossibleBreakpointsStr) == 0) {
report_set |= SourceReport::kPossibleBreakpoints;
+ } else if (strcmp(*reports, SourceReport::kProfileStr) == 0) {
+ report_set |= SourceReport::kProfile;
}
reports++;
}
« no previous file with comments | « runtime/vm/profiler_test.cc ('k') | runtime/vm/source_report.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698