Make sp variants for SkData

src/core/SkPictureData.h

Index: src/core/SkPictureData.h
diff --git a/src/core/SkPictureData.h b/src/core/SkPictureData.h
index 4e4deef55a323e7ebc10d9b7353e2a0531e458d4..3acaf579bc8e5200fda3a99ece271783faea2b8d 100644
--- a/src/core/SkPictureData.h
+++ b/src/core/SkPictureData.h
@@ -77,7 +77,7 @@ public:
 
     int opCount() const { return fContentInfo.numOperations(); }
 
-    const SkData* opData() const { return fOpData; }
+    const sk_sp<SkData>& opData() const { return fOpData; }

[scroggo, 2016/03/11 15:28:35]

We used to return a pointer to a const SkData, and now we return a const pointer
to an SkData. Is that intentional?

(I think the only non-const method on SkData is writable_data(), which will
clearly assert if called on the return value, since it will have at least two
owners.)

[reed1, 2016/03/11 19:23:34]

1. data or const_data is all the same (to me). In general I prefer data, since
90% of the time we just say type for immutables (e.g. shaders, etc.)

2. const sp is just because the method itself is const.

 
 protected:
     explicit SkPictureData(const SkPictInfo& info);
@@ -158,7 +158,7 @@ private:
     SkTArray<SkPaint>  fPaints;
     SkTArray<SkPath>   fPaths;
 
-    SkData* fOpData;    // opcodes and parameters
+    sk_sp<SkData>   fOpData;    // opcodes and parameters
 
     const SkPicture** fPictureRefs;
     int fPictureCount;