src/core/SkBitmap.cpp - Issue 1779263003: Make sp variants for SkData

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/core/SkBitmap.cpp

Issue 1779263003: Make sp variants for SkData (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: fix dynamicmemorywstream Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/core/SkBitmap.cpp

diff --git a/src/core/SkBitmap.cpp b/src/core/SkBitmap.cpp

index fdb66b378bea45fadbea5114524ed549a77a7f90..7e8e62e88b2c684adb5573a782da5cd06c47d73a 100644

--- a/src/core/SkBitmap.cpp

+++ b/src/core/SkBitmap.cpp

@@ -1163,7 +1163,7 @@ bool SkBitmap::ReadRawPixels(SkReadBuffer* buffer, SkBitmap* bitmap) {

return false;

}

- SkAutoDataUnref data(SkData::NewUninitialized(SkToSizeT(ramSize)));

+ sk_sp<SkData> data(SkData::MakeUninitialized(SkToSizeT(ramSize)));

unsigned char* dst = (unsigned char*)data->writable_data();

buffer->readByteArray(dst, SkToSizeT(snugSize));