Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1779253003:
[Reland] [Media Router] Enable autoresizing for the Media Router dialog for Mac. (Closed)
Description[Reland] [Media Router] Enable autoresizing for the Media Router dialog for Mac.
This change uses an autoresizing dialog for Media Router on Macs rather than a fixed size dialog. Previously, the dialog could only autoresize on Linux and Windows.
The original CL was reverted because it depended on a patch that was reverted. It can be found here: https://codereview.chromium.org/1680533003/
BUG=508544, 580272, 580273
Committed: https://crrev.com/d903c984042f842bf73806c4c82b27b2940569c4
Cr-Commit-Position: refs/heads/master@{#381128}
Patch Set 1 : cl 1680533003 #Patch Set 2 : Disable focus if not prompted by user. #Patch Set 3 : Fix closure compilation. #Patch Set 4 : Remove focus fixes per offline conversation (cl 1680533003). #
Messages
Total messages: 19 (14 generated)
Description was changed from ========== [Media Router] Enable autoresizing for the Media Router dialog for Mac. This change uses an autoresizing dialog for Media Router on Macs rather than a fixed size dialog. Previously, the dialog could only autoresize on Linux and Windows. Screenshots - dynamic sizing! https://screenshot.googleplex.com/vKTA1A7HXFu.png https://screenshot.googleplex.com/suVDcHMjuMY.png https://screenshot.googleplex.com/kZkoCD6n9tu.png https://screenshot.googleplex.com/iQpxy84e9CB.png https://screenshot.googleplex.com/7aYGEVB0ggX.png https://screenshot.googleplex.com/E3XZLwUGBii.png https://screenshot.googleplex.com/nBNTjvbEmjT.png https://screenshot.googleplex.com/QSEcTzbicV8.png BUG=508544, 580272, 580273 Committed: https://crrev.com/f285202a82526e75efe12b52f5b6ab62b9b6bacb Cr-Commit-Position: refs/heads/master@{#379659} patch from issue 1680533003 at patchset 40001 (http://crrev.com/1680533003#ps40001) ========== to ========== [Reland] [Media Router] Enable autoresizing for the Media Router dialog for Mac. This change uses an autoresizing dialog for Media Router on Macs rather than a fixed size dialog. Previously, the dialog could only autoresize on Linux and Windows. Screenshots - dynamic sizing! https://screenshot.googleplex.com/vKTA1A7HXFu.png https://screenshot.googleplex.com/suVDcHMjuMY.png https://screenshot.googleplex.com/kZkoCD6n9tu.png https://screenshot.googleplex.com/iQpxy84e9CB.png https://screenshot.googleplex.com/7aYGEVB0ggX.png https://screenshot.googleplex.com/E3XZLwUGBii.png https://screenshot.googleplex.com/nBNTjvbEmjT.png https://screenshot.googleplex.com/QSEcTzbicV8.png The original CL was reverted because this depends on an autoresizing patch that was reverted. The original patch can be found at: https://codereview.chromium.org/1680533003/ BUG=508544, 580272, 580273 ==========
Patchset #2 (id:20001) has been deleted
Patchset #2 (id:40001) has been deleted
Patchset #2 (id:60001) has been deleted
Patchset #2 (id:80001) has been deleted
Patchset #2 (id:100001) has been deleted
Patchset #2 (id:120001) has been deleted
Patchset #2 (id:140001) has been deleted
Description was changed from ========== [Reland] [Media Router] Enable autoresizing for the Media Router dialog for Mac. This change uses an autoresizing dialog for Media Router on Macs rather than a fixed size dialog. Previously, the dialog could only autoresize on Linux and Windows. Screenshots - dynamic sizing! https://screenshot.googleplex.com/vKTA1A7HXFu.png https://screenshot.googleplex.com/suVDcHMjuMY.png https://screenshot.googleplex.com/kZkoCD6n9tu.png https://screenshot.googleplex.com/iQpxy84e9CB.png https://screenshot.googleplex.com/7aYGEVB0ggX.png https://screenshot.googleplex.com/E3XZLwUGBii.png https://screenshot.googleplex.com/nBNTjvbEmjT.png https://screenshot.googleplex.com/QSEcTzbicV8.png The original CL was reverted because this depends on an autoresizing patch that was reverted. The original patch can be found at: https://codereview.chromium.org/1680533003/ BUG=508544, 580272, 580273 ========== to ========== [Reland] [Media Router] Enable autoresizing for the Media Router dialog for Mac. This change uses an autoresizing dialog for Media Router on Macs rather than a fixed size dialog. Previously, the dialog could only autoresize on Linux and Windows. The original CL was reverted because this depends on an autoresizing patch that was reverted. The original patch can be found at: https://codereview.chromium.org/1680533003/ BUG=508544, 580272, 580273 ==========
Description was changed from ========== [Reland] [Media Router] Enable autoresizing for the Media Router dialog for Mac. This change uses an autoresizing dialog for Media Router on Macs rather than a fixed size dialog. Previously, the dialog could only autoresize on Linux and Windows. The original CL was reverted because this depends on an autoresizing patch that was reverted. The original patch can be found at: https://codereview.chromium.org/1680533003/ BUG=508544, 580272, 580273 ========== to ========== [Reland] [Media Router] Enable autoresizing for the Media Router dialog for Mac. This change uses an autoresizing dialog for Media Router on Macs rather than a fixed size dialog. Previously, the dialog could only autoresize on Linux and Windows. The original CL was reverted because it depended on a patch that was reverted. It can be found here: https://codereview.chromium.org/1680533003/ BUG=508544, 580272, 580273 ==========
apacible@chromium.org changed reviewers: + imcheng@chromium.org
PTAL, thanks! Screenshots: https://screenshot.googleplex.com/vKTA1A7HXFu.png https://screenshot.googleplex.com/suVDcHMjuMY.png https://screenshot.googleplex.com/kZkoCD6n9tu.png https://screenshot.googleplex.com/iQpxy84e9CB.png https://screenshot.googleplex.com/7aYGEVB0ggX.png https://screenshot.googleplex.com/E3XZLwUGBii.png https://screenshot.googleplex.com/nBNTjvbEmjT.png https://screenshot.googleplex.com/QSEcTzbicV8.png
Thanks! lgtm
The CQ bit was checked by apacible@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1779253003/190001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1779253003/190001
Message was sent while issue was closed.
Description was changed from ========== [Reland] [Media Router] Enable autoresizing for the Media Router dialog for Mac. This change uses an autoresizing dialog for Media Router on Macs rather than a fixed size dialog. Previously, the dialog could only autoresize on Linux and Windows. The original CL was reverted because it depended on a patch that was reverted. It can be found here: https://codereview.chromium.org/1680533003/ BUG=508544, 580272, 580273 ========== to ========== [Reland] [Media Router] Enable autoresizing for the Media Router dialog for Mac. This change uses an autoresizing dialog for Media Router on Macs rather than a fixed size dialog. Previously, the dialog could only autoresize on Linux and Windows. The original CL was reverted because it depended on a patch that was reverted. It can be found here: https://codereview.chromium.org/1680533003/ BUG=508544, 580272, 580273 ==========
Message was sent while issue was closed.
Committed patchset #4 (id:190001)
Message was sent while issue was closed.
Description was changed from ========== [Reland] [Media Router] Enable autoresizing for the Media Router dialog for Mac. This change uses an autoresizing dialog for Media Router on Macs rather than a fixed size dialog. Previously, the dialog could only autoresize on Linux and Windows. The original CL was reverted because it depended on a patch that was reverted. It can be found here: https://codereview.chromium.org/1680533003/ BUG=508544, 580272, 580273 ========== to ========== [Reland] [Media Router] Enable autoresizing for the Media Router dialog for Mac. This change uses an autoresizing dialog for Media Router on Macs rather than a fixed size dialog. Previously, the dialog could only autoresize on Linux and Windows. The original CL was reverted because it depended on a patch that was reverted. It can be found here: https://codereview.chromium.org/1680533003/ BUG=508544, 580272, 580273 Committed: https://crrev.com/d903c984042f842bf73806c4c82b27b2940569c4 Cr-Commit-Position: refs/heads/master@{#381128} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/d903c984042f842bf73806c4c82b27b2940569c4 Cr-Commit-Position: refs/heads/master@{#381128} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
