Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issue 1779243002: Simplify StackFrameDepth's handling of stack limits. (Closed)

Created:
4 years, 9 months ago by sof
Modified:
4 years, 9 months ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, oilpan-reviews, Mads Ager (chromium), blink-reviews, kinuko+watch, kouhei+heap_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Simplify StackFrameDepth's handling of stack limits. The handling of enabled/disabled and limits has become unnecessarily complex. Especially so now that supported targets all have reasonable estimates about safe thread stack sizes. Simplify asserts and limit checks accordingly. R=haraken BUG=420515 Committed: https://crrev.com/c8095676b45ea3ea4b4906b6277301b5807d08dc Cr-Commit-Position: refs/heads/master@{#380566}

Patch Set 1 #

Patch Set 2 : fix isAcceptableStackUse() predicate #

Patch Set 3 : fix (un)signed mismatch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -41 lines) Patch
M third_party/WebKit/Source/platform/heap/StackFrameDepth.h View 1 2 3 chunks +17 lines, -22 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/StackFrameDepth.cpp View 3 chunks +2 lines, -19 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
sof
please take a look
4 years, 9 months ago (2016-03-10 22:32:55 UTC) #2
haraken
LGTM
4 years, 9 months ago (2016-03-10 23:38:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1779243002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1779243002/40001
4 years, 9 months ago (2016-03-11 06:07:32 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 9 months ago (2016-03-11 07:11:08 UTC) #8
commit-bot: I haz the power
4 years, 9 months ago (2016-03-11 07:13:07 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/c8095676b45ea3ea4b4906b6277301b5807d08dc
Cr-Commit-Position: refs/heads/master@{#380566}

Powered by Google App Engine
This is Rietveld 408576698