Issue 177923012: android: Remove unused codegen_input_paths and library_manifest_paths.

Issue 177923012: android: Remove unused codegen_input_paths and library_manifest_paths. (Closed)

Created:
6 years, 9 months ago by Nico

Modified:
6 years, 9 months ago

Reviewers:
cjhopman

CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

android: Remove unused codegen_input_paths and library_manifest_paths. As far as I can tell, nothing ever sets them. Remove them and the ant code that runs only when library_manifest_paths is set. No intended behavior change. BUG=177552 R=cjhopman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255971

Patch Set 1 #

Total comments: 2

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -29 lines)			Patch
	M	build/android/ant/apk-codegen.xml	View		2 chunks	+1 line, -21 lines	2 comments	Download
	M	build/java_apk.gypi	View		6 chunks	+0 lines, -8 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Nico

I've never touched a production ant build file before, so not sure if that part ...

6 years, 9 months ago (2014-03-06 22:09:41 UTC) #1

Nico

Committed patchset #1 manually as r255971 (presubmit successful).

6 years, 9 months ago (2014-03-10 18:06:28 UTC) #5

cjhopman

https://codereview.chromium.org/177923012/diff/1/build/android/ant/apk-codegen.xml File build/android/ant/apk-codegen.xml (right): https://codereview.chromium.org/177923012/diff/1/build/android/ant/apk-codegen.xml#newcode83 build/android/ant/apk-codegen.xml:83: manifest="${out.manifest.abs.file}" This should be: manifest="${manifest.abs.file}"

6 years, 9 months ago (2014-03-10 20:04:56 UTC) #6

Nico

6 years, 9 months ago (2014-03-10 20:10:24 UTC) #7

Message was sent while issue was closed.

https://codereview.chromium.org/177923012/diff/1/build/android/ant/apk-codege...
File build/android/ant/apk-codegen.xml (right):

https://codereview.chromium.org/177923012/diff/1/build/android/ant/apk-codege...
build/android/ant/apk-codegen.xml:83: manifest="${out.manifest.abs.file}"
On 2014/03/10 20:04:57, cjhopman wrote:
> This should be: manifest="${manifest.abs.file}"

https://codereview.chromium.org/193163004/ , thanks.

(I wonder why the try bot was happy, apk-codegen.xml is listed as input…oh, the
generated AndroidManifest.xml was still in the out directory without a clobber.)

Expand Messages | Collapse Messages