Issue 177923011: Chromium side of moving clearContextMenu from WebViewClient to WebFrameClient.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 177923011: Chromium side of moving clearContextMenu from WebViewClient to WebFrameClient. (Closed)

Created:
6 years, 9 months ago by jam

Modified:
6 years, 9 months ago

Reviewers:
jamesr

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, site-isolation-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Chromium side of moving clearContextMenu from WebViewClient to WebFrameClient. BUG=304341 R=jamesr@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255479

Total comments: 1

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -0 lines)			Patch
	M	content/renderer/render_frame_impl.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	content/renderer/render_frame_impl.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

jamesr

lgtm but you should be perfectly fine landing this without the #if guards. There's a ...

6 years, 9 months ago (2014-03-06 21:59:26 UTC) #2

jam

On 2014/03/06 21:59:26, jamesr wrote: > lgtm but you should be perfectly fine landing this ...

6 years, 9 months ago (2014-03-06 22:01:07 UTC) #3

cool :)