Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 177923007: Move AppendFile and *CurrentDirectory to the base namespace. (Closed)

Created:
6 years, 9 months ago by brettw
Modified:
6 years, 9 months ago
Reviewers:
jam
CC:
chromium-reviews, vandebo (ex-Chrome), aandrey+blink_chromium.org, cbentzel+watch_chromium.org, vsevik, grt+watch_chromium.org, jam, joi+watch-content_chromium.org, darin-cc_chromium.org, devtools-reviews_chromium.org, erikwright+watch_chromium.org, fischman+watch_chromium.org, feature-media-reviews_chromium.org, paulirish+reviews_chromium.org, piman+watch_chromium.org, jochen+watch_chromium.org, Lei Zhang, mcasas+watch_chromium.org, yurys, tommycli, eroman, pfeldman, Greg Billock, wjia+watch_chromium.org, mmenke
Visibility:
Public.

Description

Move AppendFile and *CurrentDirectory to the base namespace. This moves AppendFile, GetCurrentDirectory, and SetCurrentDirectory to the base namespace. TBR=jam Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=256309

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -88 lines) Patch
M base/file_util.h View 1 chunk +9 lines, -9 lines 0 comments Download
M base/file_util_posix.cc View 2 chunks +33 lines, -33 lines 0 comments Download
M base/file_util_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M base/file_util_win.cc View 1 2 3 4 3 chunks +21 lines, -20 lines 0 comments Download
M base/native_library_win.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M base/path_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chrome_process_finder_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/devtools/devtools_file_helper.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media_galleries/linux/mtp_read_file_worker.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/media_galleries/win/mtp_device_operations_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/net_log_temp_file_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/net/url_fixer_upper.cc View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/installer/setup/uninstall.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/policy/core/common/policy_loader_win_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/gpu/media/vaapi_h264_decoder_unittest.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M content/common/gpu/media/video_encode_accelerator_unittest.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M content/shell/browser/shell_browser_main.cc View 1 chunk +1 line, -1 line 0 comments Download
M gin/shell/gin_main.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/url_request/url_request_unittest.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/filesystem_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/function_exec_script.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/setup.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
brettw
6 years, 9 months ago (2014-03-06 19:23:42 UTC) #1
brettw
6 years, 9 months ago (2014-03-11 20:59:07 UTC) #2
Message was sent while issue was closed. 
Committed patchset #5 manually as r256309 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698