Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(473)

Issue 1779153002: Make source information on conditions mandatory in CPS (Closed)

Created:
4 years, 9 months ago by Johnni Winther
Modified:
4 years, 9 months ago
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Make source information on conditions mandatory in CPS BUG= R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/4dd2360452fb29af1e5bdb4067437f2a28c4796f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+238 lines, -171 lines) Patch
M pkg/compiler/lib/src/cps_ir/cps_fragment.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart View 23 chunks +49 lines, -26 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart View 19 chunks +43 lines, -21 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart View 4 chunks +18 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/io/position_information.dart View 1 chunk +6 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/io/source_information.dart View 1 chunk +6 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/codegen/codegen.dart View 2 chunks +88 lines, -81 lines 0 comments Download
M pkg/compiler/lib/src/tree_ir/optimization/statement_rewriter.dart View 1 chunk +4 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/tree_ir/tree_ir_builder.dart View 5 chunks +14 lines, -7 lines 0 comments Download
M pkg/compiler/lib/src/tree_ir/tree_ir_nodes.dart View 2 chunks +7 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/sourcemaps/source_mapping_invokes_test.dart View 1 chunk +1 line, -11 lines 0 comments Download
M tests/compiler/dart2js/sourcemaps/source_mapping_operators_test.dart View 2 chunks +0 lines, -15 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
4 years, 9 months ago (2016-03-10 14:22:07 UTC) #2
Siggi Cherem (dart-lang)
lgtm
4 years, 9 months ago (2016-03-10 17:50:41 UTC) #3
Johnni Winther
4 years, 9 months ago (2016-03-11 14:08:22 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4dd2360452fb29af1e5bdb4067437f2a28c4796f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698