Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Unified Diff: src/compiler.cc

Issue 1779123003: [compiler] Sidestep optimizing of generator resumers. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@local_interpreter-generators-disable-1
Patch Set: Rebased. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/bootstrapper.cc ('k') | src/compiler/ast-graph-builder.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler.cc
diff --git a/src/compiler.cc b/src/compiler.cc
index ef5d7f8514054a2a7bc9b4f8a9465dd1b8296568..755be2a3e525a23a102b5f36f189359fde32e377 100644
--- a/src/compiler.cc
+++ b/src/compiler.cc
@@ -383,6 +383,14 @@ OptimizedCompileJob::Status OptimizedCompileJob::CreateGraph() {
return AbortOptimization(kFunctionBeingDebugged);
}
+ // Resuming a suspended frame is not supported by Crankshaft/TurboFan.
+ if (info()->shared_info()->HasBuiltinFunctionId() &&
+ (info()->shared_info()->builtin_function_id() == kGeneratorObjectNext ||
+ info()->shared_info()->builtin_function_id() == kGeneratorObjectReturn ||
+ info()->shared_info()->builtin_function_id() == kGeneratorObjectThrow)) {
+ return AbortOptimization(kGeneratorResumeMethod);
+ }
+
// Limit the number of times we try to optimize functions.
const int kMaxOptCount =
FLAG_deopt_every_n_times == 0 ? FLAG_max_opt_count : 1000;
« no previous file with comments | « src/bootstrapper.cc ('k') | src/compiler/ast-graph-builder.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698