Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1779083003:
Ensure only fractional floats are converted to SkFixed in SubpixelAlignment. (Closed)
|
Created:
4 years, 9 months ago by dogben Modified:
4 years, 9 months ago Reviewers:
bungeman-skia CC:
jcgregorio, mtklein, reviews_skia.org Base URL:
https://skia.googlesource.com/skia@master Target Ref:
refs/heads/master Project:
skia Visibility:
Public. |
DescriptionEnsure only fractional floats are converted to SkFixed in SubpixelAlignment.
BUG=skia:4632
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1779083003
Committed: https://skia.googlesource.com/skia/+/db6bd3239fd5e35797a9aa36eb0044ecbe5557c4
Patch Set 1 : #
Total comments: 3
Messages
Total messages: 21 (10 generated)
Description was changed from ========== Ensure only fractional floats are converted to SkFixed in SubpixelAlignment. BUG=skia: ========== to ========== Ensure only fractional floats are converted to SkFixed in SubpixelAlignment. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
The CQ bit was checked by benjaminwagner@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1779083003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1779083003/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Patchset #1 (id:1) has been deleted
The CQ bit was checked by benjaminwagner@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1779083003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1779083003/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Ensure only fractional floats are converted to SkFixed in SubpixelAlignment. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== Ensure only fractional floats are converted to SkFixed in SubpixelAlignment. BUG=skia:4632 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
benjaminwagner@google.com changed reviewers: + bungeman@google.com
https://codereview.chromium.org/1779083003/diff/20001/src/core/SkFindAndPlace... File src/core/SkFindAndPlaceGlyph.h (right): https://codereview.chromium.org/1779083003/diff/20001/src/core/SkFindAndPlace... src/core/SkFindAndPlaceGlyph.h:388: return {SkScalarToFixed(SkScalarFraction(position.fX) + kSubpixelRounding), 0}; SkScalarFraction is currently really super slow. I'll see about speeding it up a bit first... https://codereview.chromium.org/1783583003/
https://codereview.chromium.org/1779083003/diff/20001/src/core/SkFindAndPlace... File src/core/SkFindAndPlaceGlyph.h (right): https://codereview.chromium.org/1779083003/diff/20001/src/core/SkFindAndPlace... src/core/SkFindAndPlaceGlyph.h:388: return {SkScalarToFixed(SkScalarFraction(position.fX) + kSubpixelRounding), 0}; On 2016/03/10 at 20:55:58, bungeman1 wrote: > SkScalarFraction is currently really super slow. I'll see about speeding it up a bit first... https://codereview.chromium.org/1783583003/ I maybe ought to always return positive numbers too. Or just return SubpixelRound units.
https://codereview.chromium.org/1779083003/diff/20001/src/core/SkFindAndPlace... File src/core/SkFindAndPlaceGlyph.h (right): https://codereview.chromium.org/1779083003/diff/20001/src/core/SkFindAndPlace... src/core/SkFindAndPlaceGlyph.h:388: return {SkScalarToFixed(SkScalarFraction(position.fX) + kSubpixelRounding), 0}; On 2016/03/10 21:16:22, Ben Wagner wrote: > On 2016/03/10 at 20:55:58, bungeman1 wrote: > > SkScalarFraction is currently really super slow. I'll see about speeding it up > a bit first... https://codereview.chromium.org/1783583003/ > > I maybe ought to always return positive numbers too. Or just return > SubpixelRound units. Always returning positive numbers would just be extra work. I suppose if we had SkSubpixelRound units we could save a shift since (in the big picture) we really just want the fractional part * 2^SkGlyph::kSubBits as an int so we can discretize. (These values are just passed along until they are shoved into a call to SkGlyph::MakeID.) But that's more difficult to do.
lgtm
The CQ bit was checked by benjaminwagner@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1779083003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1779083003/20001
Message was sent while issue was closed.
Description was changed from ========== Ensure only fractional floats are converted to SkFixed in SubpixelAlignment. BUG=skia:4632 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== Ensure only fractional floats are converted to SkFixed in SubpixelAlignment. BUG=skia:4632 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... Committed: https://skia.googlesource.com/skia/+/db6bd3239fd5e35797a9aa36eb0044ecbe5557c4 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as https://skia.googlesource.com/skia/+/db6bd3239fd5e35797a9aa36eb0044ecbe5557c4 |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
