bluetooth: Test & make StartNotifySession reentrant.

device/bluetooth/bluetooth_gatt_descriptor_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/run_loop.h"
 #include "device/bluetooth/bluetooth_gatt_characteristic.h"
 #include "device/bluetooth/bluetooth_gatt_service.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 #if defined(OS_ANDROID)
@@ skipping 76 matching lines @@
   SimulateGattCharacteristic(service2, uuid, /* properties */ 0);
   SimulateGattCharacteristic(service3, uuid, /* properties */ 0);
   SimulateGattCharacteristic(service3, uuid, /* properties */ 0);
   BluetoothGattCharacteristic* char1 = service1->GetCharacteristics()[0];
   BluetoothGattCharacteristic* char2 = service1->GetCharacteristics()[1];
   BluetoothGattCharacteristic* char3 = service2->GetCharacteristics()[0];
   BluetoothGattCharacteristic* char4 = service2->GetCharacteristics()[1];
   BluetoothGattCharacteristic* char5 = service3->GetCharacteristics()[0];
   BluetoothGattCharacteristic* char6 = service3->GetCharacteristics()[1];
   // 6 descriptors (same UUID), 1 on each characteristic
-  // TODO(crbug.com/576900) Test multiple descriptors with same UUID on one
+  // TODO(576900) Test multiple descriptors with same UUID on one
   // characteristic.
   SimulateGattDescriptor(char1, uuid);
   SimulateGattDescriptor(char2, uuid);
   SimulateGattDescriptor(char3, uuid);
   SimulateGattDescriptor(char4, uuid);
   SimulateGattDescriptor(char5, uuid);
   SimulateGattDescriptor(char6, uuid);
   BluetoothGattDescriptor* desc1 = char1->GetDescriptors()[0];
   BluetoothGattDescriptor* desc2 = char2->GetDescriptors()[0];
   BluetoothGattDescriptor* desc3 = char3->GetDescriptors()[0];
@@ skipping 87 matching lines @@
 // Tests WriteRemoteDescriptor with empty value buffer.
 TEST_F(BluetoothGattDescriptorTest, WriteRemoteDescriptor_Empty) {
   ASSERT_NO_FATAL_FAILURE(FakeDescriptorBoilerplate());
 
   std::vector<uint8_t> empty_vector;
   descriptor1_->WriteRemoteDescriptor(empty_vector, GetCallback(Call::EXPECTED),
                                       GetGattErrorCallback(Call::NOT_EXPECTED));
   EXPECT_EQ(1, gatt_write_descriptor_attempts_);
   SimulateGattDescriptorWrite(descriptor1_);
 
+  // Duplicate write reported from OS shouldn't cause a problem:
+  SimulateGattDescriptorWrite(descriptor1_);
+
   EXPECT_EQ(empty_vector, last_write_value_);
 }
 #endif  // defined(OS_ANDROID)
 
 #if defined(OS_ANDROID)
 // Tests ReadRemoteDescriptor completing after Chrome objects are deleted.
 TEST_F(BluetoothGattDescriptorTest, ReadRemoteDescriptor_AfterDeleted) {
   ASSERT_NO_FATAL_FAILURE(FakeDescriptorBoilerplate());
 
   descriptor1_->ReadRemoteDescriptor(GetReadValueCallback(Call::NOT_EXPECTED),
                                      GetGattErrorCallback(Call::NOT_EXPECTED));
 
   RememberDescriptorForSubsequentAction(descriptor1_);
-  DeleteDevice(device_);
+  DeleteDevice(device_);  // TODO(576906) delete only the descriptor.
 
   std::vector<uint8_t> empty_vector;
   SimulateGattDescriptorRead(/* use remembered descriptor */ nullptr,
                              empty_vector);
   EXPECT_TRUE("Did not crash!");
 }
 #endif  // defined(OS_ANDROID)
 
 #if defined(OS_ANDROID)
 // Tests WriteRemoteDescriptor completing after Chrome objects are deleted.
 TEST_F(BluetoothGattDescriptorTest, WriteRemoteDescriptor_AfterDeleted) {
   ASSERT_NO_FATAL_FAILURE(FakeDescriptorBoilerplate());
 
   std::vector<uint8_t> empty_vector;
   descriptor1_->WriteRemoteDescriptor(empty_vector,
                                       GetCallback(Call::NOT_EXPECTED),
                                       GetGattErrorCallback(Call::NOT_EXPECTED));
 
   RememberDescriptorForSubsequentAction(descriptor1_);
-  DeleteDevice(device_);
+  DeleteDevice(device_);  // TODO(576906) delete only the descriptor.
 
   SimulateGattDescriptorWrite(/* use remembered descriptor */ nullptr);
   EXPECT_TRUE("Did not crash!");
 }
 #endif  // defined(OS_ANDROID)
 
 #if defined(OS_ANDROID)
 // Tests ReadRemoteDescriptor and GetValue with non-empty value buffer.
 TEST_F(BluetoothGattDescriptorTest, ReadRemoteDescriptor) {
   ASSERT_NO_FATAL_FAILURE(FakeDescriptorBoilerplate());
@@ skipping 338 matching lines @@
 
   // Initial read should still succeed:
   ResetEventCounts();
   SimulateGattDescriptorRead(descriptor1_, empty_vector);
   EXPECT_EQ(1, callback_count_);
   EXPECT_EQ(0, error_callback_count_);
 }
 #endif  // defined(OS_ANDROID)
 
 }  // namespace device