Expose the selection root bounds in WebView.

Source/web/WebViewImpl.cpp

 /*
  * Copyright (C) 2011, 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 2126 matching lines @@
     scaledAnchor.scale(pageScaleFactor());
     scaledFocus.scale(pageScaleFactor());
     anchor = scaledAnchor;
     focus = scaledFocus;
 
     if (!selection.selection().isBaseFirst())
         std::swap(anchor, focus);
     return true;
 }
 
+bool WebViewImpl::selectionRootBounds(WebRect& bounds) const
+{
+    const LocalFrame* frame = focusedWebCoreFrame();
+    if (!frame)
+        return false;
+
+    Element* root = frame->selection().rootEditableElementOrDocumentElement();
+    if (!root)
+        return false;
+
+    // If the selection is inside a form control, the root will be a <div> that

[timvolodine, 2014/03/06 17:02:02]

What about textarea elements? Could you list all cases here where the
root->shadowHost() is required?

[mlamouri (slow - plz ping), 2014/03/10 16:05:59]

Done.

+    // behaves as the editor but we want to return the actual element's bounds.
+    if (root->shadowHost()
+        && (root->shadowHost()->hasTagName(HTMLNames::textareaTag)
+            || (root->shadowHost()->hasTagName(HTMLNames::inputTag)
+                && toHTMLInputElement(root->shadowHost())->isText()))) {

[timvolodine, 2014/03/05 19:41:02]

no single-line brackets

[mlamouri (slow - plz ping), 2014/03/06 13:45:31]

Given the size of the condition, I think having brackets is fair.

[timvolodine, 2014/03/06 17:02:02]

I was actually referring to:
http://dev.chromium.org/blink/coding-style#TOC-Indentation, item5.
Yes the condition looks a bit heavy, maybe it makes sense to put
root->shadowHost() in a local variable to make it more compact and avoid
repetitions..

[mlamouri (slow - plz ping), 2014/03/10 16:05:59]

I fixed the brackets. Switching to root->shadowHost() to shadowHost
unfortunately doesn't make the condition more readable.

[timvolodine, 2014/03/10 17:50:00]

The more I look at this now the more I am for putting the root->shadowHost()
into a local variable. There are 5x root->shadowHost() calls which are not
completely trivial, so this will save some CPU work (in addition to making the
code more compact).

+        root = root->shadowHost();
+    }
+
+    IntRect boundingBox = root->pixelSnappedBoundingBox();
+    boundingBox = root->document().frame()->view()->contentsToWindow(boundingBox);
+    boundingBox.scale(pageScaleFactor());
+    bounds = boundingBox;
+
+    return true;
+}
+
 InputMethodContext* WebViewImpl::inputMethodContext()
 {
     if (!m_imeAcceptEvents)
         return 0;
 
     LocalFrame* focusedFrame = focusedWebCoreFrame();
     if (!focusedFrame)
         return 0;
 
     Element* target = focusedFrame->document()->focusedElement();
@@ skipping 1817 matching lines @@
     const PageScaleConstraints& constraints = m_pageScaleConstraintsSet.pageDefinedConstraints();
 
     if (!mainFrameImpl() || !mainFrameImpl()->frameView())
         return false;
 
     return mainFrameImpl()->frameView()->layoutSize().width() == m_size.width
         || (constraints.minimumScale == constraints.maximumScale && constraints.minimumScale != -1);
 }
 
 } // namespace blink