Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 1778963003: rewrite_to_chrome_style: Exclude methods before checking IsBlinkOrWTF (Closed)

Created:
4 years, 9 months ago by danakj
Modified:
4 years, 9 months ago
Reviewers:
dcheng
CC:
dcheng, chromium-reviews, piman, Nico
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

rewrite_to_chrome_style: Exclude methods before checking IsBlinkOrWTF The IsBlinkOrWTFMethod asserts that the method is not doing crazy overrides, but it will fire for destructors which we aren't trying to rename anyways. So exclude those before trying to see if we want to rename it. R=dcheng BUG=593446 Committed: https://crrev.com/e27ff645c0bfb460855b825f08beda583d71a8e5 Cr-Commit-Position: refs/heads/master@{#380228}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp View 2 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
danakj
4 years, 9 months ago (2016-03-09 20:46:05 UTC) #1
dcheng
lgtm
4 years, 9 months ago (2016-03-09 21:01:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1778963003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1778963003/1
4 years, 9 months ago (2016-03-09 21:03:05 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-09 21:30:07 UTC) #5
commit-bot: I haz the power
4 years, 9 months ago (2016-03-09 21:31:46 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e27ff645c0bfb460855b825f08beda583d71a8e5
Cr-Commit-Position: refs/heads/master@{#380228}

Powered by Google App Engine
This is Rietveld 408576698