Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1121)

Issue 1778893002: Fix build at 2f4232d. (Closed)

Created:
4 years, 9 months ago by Oliver Chang
Modified:
4 years, 9 months ago
Reviewers:
Tom Sepez, Nico
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M build/standalone.gypi View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Oliver Chang
TBR
4 years, 9 months ago (2016-03-09 17:26:52 UTC) #1
Oliver Chang
Committed patchset #1 (id:1) manually as 4f0b7a61e473996df776dbd9a8d1af3a9704110d (tree was closed).
4 years, 9 months ago (2016-03-09 17:28:22 UTC) #3
Nico
huh, what's the error without this? VCCLCompilerTool should be ignored everywhere but windows, so this ...
4 years, 9 months ago (2016-03-09 18:20:27 UTC) #4
Oliver Chang
On 2016/03/09 18:20:27, Nico wrote: > huh, what's the error without this? VCCLCompilerTool should be ...
4 years, 9 months ago (2016-03-09 18:23:33 UTC) #5
Nico
4 years, 9 months ago (2016-03-09 18:29:02 UTC) #6
Message was sent while issue was closed.
Ah, thanks.

For posterity, since bot logs will expire and rietveld won't:

gyp: name 'MSVS_VERSION' is not defined while evaluating condition 'clang==1 and
MSVS_VERSION == "2013"' in
/mnt/data/b/build/slave/linux/build/pdfium/build/all.gyp
Error: Command '/usr/bin/python pdfium/build/gyp_pdfium' returned non-zero exit
status 1 in /mnt/data/b/build/slave/linux/build

Powered by Google App Engine
This is Rietveld 408576698