chrome/browser/lifetime/keep_alive_types.h - Issue 1778873002: Replace Increment/DecrementKeepAliveCount by ScopedKeepAlives

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/lifetime/keep_alive_types.h

Issue 1778873002: Replace Increment/DecrementKeepAliveCount by ScopedKeepAlives (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@KAObserver

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/lifetime/application_lifetime_aura.cc ('K') | « chrome/browser/lifetime/keep_alive_registry_unittest.cc ('k') | chrome/browser/lifetime/keep_alive_types.cc » ('j') | chrome/test/base/testing_browser_process.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/lifetime/keep_alive_types.h

diff --git a/chrome/browser/lifetime/keep_alive_types.h b/chrome/browser/lifetime/keep_alive_types.h

index e41d5c1ce523e9e58d436aa7ee866f654b51dc07..59ec9100f83899e7e5a9650a132ed58db83e1884 100644

--- a/chrome/browser/lifetime/keep_alive_types.h

+++ b/chrome/browser/lifetime/keep_alive_types.h

@@ -14,14 +14,22 @@

// Refers to the what the KeepAlive's lifetime is tied to, to help debugging.

enum class KeepAliveOrigin {

+ // c/b

+ APP_CONTROLLER,

+ BROWSER_PROCESS_CHROMEOS,

// c/b/background

BACKGROUND_MODE_MANAGER,

BACKGROUND_MODE_MANAGER_STARTUP,

+ // c/b/chromeos

+ LOGIN_DISPLAY_HOST_IMPL,

// c/b/ui

APP_LIST_SERVICE_VIEWS,

APP_LIST_SHOWER,

CHROME_APP_DELEGATE,

+ PANEL,

PANEL_VIEW,

PROFILE_LOADER,

USER_MANAGER_VIEW